Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum seeding time too long #409

Closed
sbfnk opened this issue Jul 3, 2023 · 0 comments · Fixed by #413
Closed

Minimum seeding time too long #409

sbfnk opened this issue Jul 3, 2023 · 0 comments · Fixed by #413

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Jul 3, 2023

The minimum seeding time as a function of the generation time is one time step too long

EpiNow2/R/get.R

Line 324 in d0bea23

sum(generation_time$max) + sum(generation_time$np_pmf_max)

Since the first sum over past infections is calcluated at time seeding_time + 1, if the seeding time is as long as the truncated pmf of the generation time distribution, the first element of the sum is at time step 2, not 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant