Set C++17 as a system requirement #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checking devel I see that the C++14 note has been resolved and that all CI tests etc are passing as expected. Just waiting on synthetic validation then will merge and resubmit to CRAN. |
|
(@sbfnk tagged you for forms sake but I think this doesn't really need a review if all checks are passing) |
|
Synthetic validation all looks good to me. |
|
This looks good to me. Will merge into main now and resubmit tomorrow evening as long as no issues show up. |
sbfnk
pushed a commit
that referenced
this pull request
May 3, 2024
Set C++17 as a system requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the new CRAN requirements this PR sets C++17 as a package requirement. The adjustment made here is based on recommendations in this thread.