Skip to content

Commit

Permalink
Merge pull request #364 from epiforecasts/update-to-c++17
Browse files Browse the repository at this point in the history
Set C++17 as a system requirement
  • Loading branch information
seabbs authored Feb 8, 2023
2 parents dd484e2 + b2dc511 commit 48d60d0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -139,4 +139,5 @@ Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
NeedsCompilation: yes
SystemRequirements: GNU make
C++17
VignetteBuilder: knitr
5 changes: 2 additions & 3 deletions configure
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#! /bin/sh

# Generated by rstantools. Do not edit by hand.

"${R_HOME}/bin/Rscript" -e "rstantools::rstan_config()"
#! /bin/sh
"${R_HOME}/bin/Rscript" -e "rstantools::rstan_config()" -e 'writeLines(sub("CXX14$", "CXX17", readLines("src/Makevars")), "src/Makevars")'
5 changes: 2 additions & 3 deletions configure.win
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#! /bin/sh

# Generated by rstantools. Do not edit by hand.

"${R_HOME}/bin${R_ARCH_BIN}/Rscript.exe" -e "rstantools::rstan_config()"
#! /bin/sh
"${R_HOME}/bin${R_ARCH_BIN}/Rscript.exe" -e "rstantools::rstan_config()" -e 'writeLines(sub("CXX14$", "CXX17", readLines("src/Makevars.win")), "src/Makevars.win")'
4 changes: 3 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,6 @@

All issues flagged by CRAN have been resolved. In particular the roxygen2 documentation issue that was flagged as the reason for archiving has been resolved by rebuilding the documentation. The change in policy to no longer allow a non-CRAN package as a suggest has also been resolved by removing this functionality.

Additional CRAN comments flagged post archiving (i.e temporary directory usage, no examples for internal functions, and no return values) have been updated as requested where action was required to comply with CRAN policies.
Additional CRAN comments flagged post archiving (i.e temporary directory usage, no examples for internal functions, and no return values) have been updated as requested where action was required to comply with CRAN policies.

C++17 has been made a system requirement as requested by CRAN. Whilst rstan (on which we depend) currently only supports C++14 the package compiles as expected and passes all tests on C++17.

0 comments on commit 48d60d0

Please sign in to comment.