[3.2] cleos: add get supported_protocol_features and system activate subcommands #663

linh2931 · 2022-07-13T01:08:22Z

Backport EOSIO/eos#10036 spiritually. Resolve #462

Add get supported_protocol_features and system activate to cleos such that protocol features can be activated by using their names; no feature digests are needed.

The feature was totally rewritten. Hardcodied protocol feature names and digests are removed. User can use get supported_protocol_features to find a list of supported feature names. Command description was cleaned up and PREACTIVATE_FEATURE was removed as it is not possible to activate it using activate action from eosio.boot (RPC schedule_protocol_feature_activations must be used).

Find supported protocol features

./cleos get supported_protocol_features
ONLY_LINK_TO_EXISTING_PERMISSION
FORWARD_SETCODE
WTMSIG_BLOCK_SIGNATURES
GET_BLOCK_NUM
REPLACE_DEFERRED
NO_DUPLICATE_DEFERRED_ID
RAM_RESTRICTIONS
WEBAUTHN_KEY
BLOCKCHAIN_PARAMETERS
DISALLOW_EMPTY_PRODUCER_SCHEDULE
CRYPTO_PRIMITIVES
ONLY_BILL_FIRST_AUTHORIZER
RESTRICT_ACTION_TO_SELF
GET_CODE_HASH
ACTION_RETURN_VALUE
CONFIGURABLE_WASM_LIMITS2
FIX_LINKAUTH_RESTRICTION
GET_SENDER

Activate a protocol feature

./cleos system activate WTMSIG_BLOCK_SIGNATURES
executed transaction: 667479cd2280739b21b925c1c9cddc2d8dc46626f0ecc61173aec5f092431c61  128 bytes  179 us
#         eosio <= eosio::activate              {"feature_digest":"299dcb6af692324b899b39f16d5a530a33062804e41f09dc97e9f156b4476707"}
warn  2022-07-16T01:51:13.001 cleos     main.cpp:665                  print_result       warning: transaction executed locally, but may not be confirmed by the network yet

Activate an unknown protocol feature

./cleos system activate ABCD
ABCD is unknown. Following protocol features are supported

ONLY_LINK_TO_EXISTING_PERMISSION
FORWARD_SETCODE
WTMSIG_BLOCK_SIGNATURES
GET_BLOCK_NUM
REPLACE_DEFERRED
NO_DUPLICATE_DEFERRED_ID
RAM_RESTRICTIONS
WEBAUTHN_KEY
BLOCKCHAIN_PARAMETERS
DISALLOW_EMPTY_PRODUCER_SCHEDULE
CRYPTO_PRIMITIVES
ONLY_BILL_FIRST_AUTHORIZER
RESTRICT_ACTION_TO_SELF
GET_CODE_HASH
ACTION_RETURN_VALUE
CONFIGURABLE_WASM_LIMITS2
FIX_LINKAUTH_RESTRICTION
GET_SENDER

…ch as: cleos system activate kv_database. don't need using digest.

…ve PREACTIVATE_FEATURE as it cannot be activated via activate action

larryk85 · 2022-07-14T00:24:07Z

programs/cleos/main.cpp

+   activate_subcommand(CLI::App* actionRoot) {
+      auto activate = actionRoot->add_subcommand("activate", localized("Activate protocol feature by name"));
+      activate->add_option("feature",  feature_name_str,  localized("The name, one of below (lowercase also works):\n"
+                       "ONLY_LINK_TO_EXISTING_PERMISSION\n"


Can we have a way of generating these from parsing the protocol_feature_manager.cpp? We have this pattern in quite a few places as is where we have hard-coded the protocol feature names and digests. It ultimately makes it incredibly difficult to add new protocol features as all the places you have to go and fix are not connected and usually won't break certain tests, etc.

This right here please.

Thanks @larryk85 and @spoonincode I will call get_supported_protocol_features to get a list. This code will never change again when protocol features change.

heifner · 2022-07-14T00:28:41Z

programs/cleos/main.cpp

+         string action="activate";
+         string data;
+         std::locale loc;
+         vector<std::string> permissions = {"eosio"};


Would be nice to provide an option to override the default permission.

Thanks @heifner . Will add an option to provide more flexibility.

…g get_supported_protocol_features RPC; provide account and permission options

…o contact the chain in the constructor of activate_subcommand which causes problems for cleos problem initialzation when the chain is offline, and a seperate get supported_protocol_features is clearer

…workfoundation/mandel into cleos_activate_subcommand

…ctivated is unknown

…workfoundation/mandel into cleos_activate_subcommand

softprofe and others added 3 commits July 12, 2022 10:15

Add cleos system activate subcommand to activate a system feature. su…

ac6b604

…ch as: cleos system activate kv_database. don't need using digest.

enhance error handling

e1f93ac

update protocol feature list to match Mandel, clean up help, and remo…

6236f47

…ve PREACTIVATE_FEATURE as it cannot be activated via activate action

linh2931 requested review from heifner and spoonincode July 13, 2022 01:08

linh2931 self-assigned this Jul 13, 2022

larryk85 suggested changes Jul 14, 2022

View reviewed changes

heifner reviewed Jul 14, 2022

View reviewed changes

linh2931 and others added 6 commits July 14, 2022 21:37

Remove hardcodied list of protocol features and their digests by usin…

69711ea

…g get_supported_protocol_features RPC; provide account and permission options

Make descriptions of options account and permission consistent

3749a3c

Merge branch 'main' into cleos_activate_subcommand

ed63a66

Add "get supported_protocol_features" subcommand to remove the need t…

0f12128

…o contact the chain in the constructor of activate_subcommand which causes problems for cleos problem initialzation when the chain is offline, and a seperate get supported_protocol_features is clearer

Merge branch 'cleos_activate_subcommand' of https://github.com/eosnet…

3c27682

…workfoundation/mandel into cleos_activate_subcommand

Merge branch 'main' into cleos_activate_subcommand

e13e531

linh2931 changed the title ~~[3.2] cleos: add protocol feature activation subcommand~~ [3.2] cleos: add get supported_protocol_features and system activate subcommands Jul 16, 2022

linh2931 and others added 3 commits July 16, 2022 07:41

print out supported protocol features if the protocol feature to be a…

26d02d5

…ctivated is unknown

Merge branch 'cleos_activate_subcommand' of https://github.com/eosnet…

a88db15

…workfoundation/mandel into cleos_activate_subcommand

Merge branch 'main' into cleos_activate_subcommand

5a30dd8

larryk85 approved these changes Jul 18, 2022

View reviewed changes

Merge branch 'main' into cleos_activate_subcommand

c9dba88

linh2931 merged commit d6c3e25 into main Jul 19, 2022

linh2931 deleted the cleos_activate_subcommand branch July 19, 2022 01:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3.2] cleos: add get supported_protocol_features and system activate subcommands #663

[3.2] cleos: add get supported_protocol_features and system activate subcommands #663

linh2931 commented Jul 13, 2022 •

edited

Loading

larryk85 Jul 14, 2022

spoonincode Jul 14, 2022

linh2931 Jul 14, 2022

heifner Jul 14, 2022

linh2931 Jul 14, 2022

[3.2] cleos: add get supported_protocol_features and system activate subcommands #663

[3.2] cleos: add get supported_protocol_features and system activate subcommands #663

Conversation

linh2931 commented Jul 13, 2022 • edited Loading

larryk85 Jul 14, 2022

Choose a reason for hiding this comment

spoonincode Jul 14, 2022

Choose a reason for hiding this comment

linh2931 Jul 14, 2022

Choose a reason for hiding this comment

heifner Jul 14, 2022

Choose a reason for hiding this comment

linh2931 Jul 14, 2022

Choose a reason for hiding this comment

linh2931 commented Jul 13, 2022 •

edited

Loading