This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add cleos system activate subcommand (to activate system feature like kv_database) #10036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch as: cleos system activate kv_database. don't need using digest.
| std::string feature_digest = map_name_digest[feature_name_str]; | ||
| data = "[\"" + feature_digest + "\"]"; | ||
| } else { | ||
| std::cout << "Can't find system feature : " << feature_name_str << std::endl; |
There was a problem hiding this comment.
Exit when feature cannot be found.
There was a problem hiding this comment.
- Is the command format agreed by Areg?
- Add command usage to Documentation section in the PR header
yes, It is Areg's idea to add subcommand under cleos system.
There was a problem hiding this comment.
Click the documentation button in the PR and add documentation there.
There was a problem hiding this comment.
now documentation is there.
programs/cleos/main.cpp
Outdated
| fc::variant action_args_var; | ||
| if( !data.empty() ) { | ||
| action_args_var = json_from_file_or_string(data, fc::json::parse_type::relaxed_parser); | ||
| } |
There was a problem hiding this comment.
Add an else to handle error.
linhuang-blockone
suggested changes
Feb 12, 2021
linhuang-blockone
approved these changes
Feb 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Start 10036 description ......
EPE 453
Add cleos system activate subcommand (to activate system feature like kv_database)
you can find usage by: cleos system activate -h
support all system features. support uppercase and lowercase kv_database or KV_DATABASE or KV_database
using : cleos system activate kv_database
instead of using cleos push action eosio activate '["825ee6288fb1373eab1b5187ec2f04f6eacb39cb3a97f356a07c91622dd61d16"]' -p eosio
End 10036 description ......
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions
new subcommand cleos system activate
see usage by: cleos system activate -h
example: cleos system activate kv_database
cleos system activate KV_DATABASE
cleos system activate KV_database
note : feature name argument is not sensitive to uppercase or lowercase