Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health check failed if no active redis connection #310

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

debbyku
Copy link
Contributor

@debbyku debbyku commented Nov 1, 2021

The original PR: #308

@debbyku
Copy link
Contributor Author

debbyku commented Nov 1, 2021

@ysawa0 I reset my branch then committed the files again. I should do it on my 2nd PR. Just not familiar with GIT. Thanks for your time to review it again.

Copy link
Member

@ysawa0 ysawa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@ysawa0 ysawa0 merged commit 330a681 into envoyproxy:main Nov 7, 2021
timcovar pushed a commit to goatapp/ratelimit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants