2rd PR for reporting health check failure if there is no active redis connection #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysawa0
reviewed
Oct 26, 2021
src/redis/cache_impl.go
Outdated
| var perSecondPool Client | ||
| if s.RedisPerSecond { | ||
| perSecondPool = NewClientImpl(srv.Scope().Scope("redis_per_second_pool"), s.RedisPerSecondTls, s.RedisPerSecondAuth, s.RedisPerSecondSocketType, | ||
| s.RedisPerSecondType, s.RedisPerSecondUrl, s.RedisPerSecondPoolSize, s.RedisPerSecondPipelineWindow, s.RedisPerSecondPipelineLimit, s.RedisTlsConfig) | ||
| s.RedisPerSecondType, s.RedisPerSecondUrl, s.RedisPerSecondPoolSize, s.RedisPerSecondPipelineWindow, s.RedisPerSecondPipelineLimit, s.RedisTlsConfig, healthCheckActiveConnection, srv) |
There was a problem hiding this comment.
can't we reference s.RedisHealthCheckActiveConnection instead of introducing new healthCheckActiveConnection arg to this function?
ysawa0
approved these changes
Oct 27, 2021
|
@ysawa0 very sorry that it is quite difficult for me to do the DCO git rebase HEAD~21 --signoff it includes other PR merged codes, I am afraid I will do something wrong on it. Not sure what is the best way to do it |
|
The DCO is required I believe so you would need to start a new branch off latest and commit on top of that to fix |
|
Thanks for the suggestion. I will fork a new branch and do it again in few
days. Thanks for your time to review it again.
在 2021年10月29日週五 09:07，Yuki Sawa ***@***.***> 寫道：
… The DCO is required I believe so you would need to start a new branch off
latest and commit on top of that to fix
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#308 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHWBE5V2ZADUS3KDCN4H6TTUJHXW5ANCNFSM5GRYYHAA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to #297