Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reuse the filewatcher for file-provider #4807

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Nov 28, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

replace #4475

Release Notes: No

@shawnh2 shawnh2 requested a review from a team as a code owner November 28, 2024 14:12
@shawnh2 shawnh2 force-pushed the reuse-filewatcher branch 2 times, most recently from baa0935 to 3496a33 Compare November 28, 2024 14:23
Signed-off-by: shawnh2 <[email protected]>
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 41.81818% with 64 lines in your changes missing coverage. Please review.

Project coverage is 66.06%. Comparing base (e6d3526) to head (6609a59).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/file/file.go 0.00% 53 Missing ⚠️
internal/provider/file/store.go 0.00% 5 Missing ⚠️
internal/filewatcher/worker.go 85.00% 2 Missing and 1 partial ⚠️
internal/utils/path/path.go 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4807      +/-   ##
==========================================
+ Coverage   65.68%   66.06%   +0.38%     
==========================================
  Files         211      209       -2     
  Lines       32064    31890     -174     
==========================================
+ Hits        21060    21069       +9     
+ Misses       9761     9578     -183     
  Partials     1243     1243              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be good if we can have some tests for file provider.

@shawnh2
Copy link
Contributor Author

shawnh2 commented Nov 29, 2024

LGTM, it would be good if we can have some tests for file provider.

Have some tests on my local env, will add them as a follow-up

@arkodg arkodg added this to the v1.3.0-rc.1 milestone Dec 3, 2024
@arkodg arkodg requested review from a team December 3, 2024 01:21
@zirain zirain merged commit 3074800 into envoyproxy:main Dec 5, 2024
23 of 24 checks passed
@shawnh2 shawnh2 deleted the reuse-filewatcher branch December 5, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants