-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reuse filewatcher #4475
reuse filewatcher #4475
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4475 +/- ##
==========================================
+ Coverage 65.61% 66.01% +0.40%
==========================================
Files 211 209 -2
Lines 31961 31774 -187
==========================================
+ Hits 20970 20977 +7
+ Misses 9752 9556 -196
- Partials 1239 1241 +2 ☔ View full report in Codecov by Sentry. |
cc @shawnh2 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done some test, seems running envoy-gateway server -c config.yaml
with config.yaml
:
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyGateway
gateway:
controllerName: gateway.envoyproxy.io/gatewayclass-controller
provider:
type: Custom
custom:
resource:
type: File
file:
paths: ["test/"]
logging:
level:
default: info
cannot catch any modifications (like vim, echo etc) under the paths
.
dba2ee1
to
be0419e
Compare
2fb121e
to
242d305
Compare
@shawnh2 can you review and test this again? |
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
25dd1ec
to
4a515d7
Compare
@shawnh2 seems you have more idea, I'd like close this one. |
filewatcher
packageutil