Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.2] fix panic in provider when the direct response body is nil (#4647) #4654

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[release/v1.2] fix panic in provider when the direct response body is nil (#4647) #4654

merged 1 commit into from
Nov 7, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Nov 7, 2024

body is an optional field, it may be nil

(cherry picked from commit ad51832)

@arkodg
fix panic in provider when the direct response body is nil (envoyprox…
368bcf1 
…y#4647)

body is an optional field, it may be nil

Signed-off-by: Arko Dasgupta <[email protected]>
(cherry picked from commit ad51832)
Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg requested a review from a team as a code owner November 7, 2024 01:44
@arkodg arkodg changed the title [release/v1.1] fix panic in provider when the direct response body is nil (#4647) [release/v1.2] fix panic in provider when the direct response body is nil (#4647) Nov 7, 2024
@arkodg arkodg requested a review from a team November 7, 2024 01:45
zhaohuabing
zhaohuabing approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arko!

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.55%. Comparing base (dd1c66f) to head (368bcf1).
Report is 1 commits behind head on release/v1.2.

Files with missing lines Patch % Lines
internal/provider/kubernetes/filters.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release/v1.2    #4654      +/-   ##
================================================
+ Coverage         65.52%   65.55%   +0.02%     
================================================
  Files               211      211              
  Lines             31942    31943       +1     
================================================
+ Hits              20930    20940      +10     
+ Misses             9765     9760       -5     
+ Partials           1247     1243       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg merged commit 18d10e8 into envoyproxy:release/v1.2 Nov 7, 2024
16 of 18 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkodg @zhaohuabing @zirain