fix panic in provider when the direct response body is nil #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
body is an optional field, it may be nil Signed-off-by: Arko Dasgupta <[email protected]>
daniel-white
approved these changes
Nov 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4647 +/- ##
=======================================
Coverage ? 65.55%
=======================================
Files ? 211
Lines ? 31946
Branches ? 0
=======================================
Hits ? 20942
Misses ? 9760
Partials ? 1244 ☔ View full report in Codecov by Sentry. |
zirain
approved these changes
Nov 6, 2024
zhaohuabing
approved these changes
Nov 7, 2024
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
Nov 7, 2024
…y#4647) body is an optional field, it may be nil Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit ad51832) Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
added a commit
that referenced
this pull request
Nov 7, 2024
… nil (#4647) (#4654) fix panic in provider when the direct response body is nil (#4647) body is an optional field, it may be nil (cherry picked from commit ad51832) Signed-off-by: Arko Dasgupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
body is an optional field, it may be nil