Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up gatewayapi v1alpha2 helpers #4482

Merged
merged 2 commits into from
Oct 21, 2024
Merged

chore: clean up gatewayapi v1alpha2 helpers #4482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51bd8ee
clean up gatewayapi v1alpha2 helpers
shawnh2 Oct 19, 2024
8c793b3
Merge branch 'main' into clean-gwapiv1a2
zhaohuabing Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 0 additions & 45 deletions internal/gatewayapi/helpers_v1alpha2.go
View file
Open in desktop

This file was deleted.

9 changes: 3 additions & 6 deletions internal/provider/kubernetes/routes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ func (r *gatewayAPIReconciler) processTLSRoutes(ctx context.Context, gatewayName

for _, rule := range tlsRoute.Spec.Rules {
for _, backendRef := range rule.BackendRefs {
ref := gatewayapi.UpgradeBackendRef(backendRef)
if err := validateBackendRef(&ref); err != nil {
if err := validateBackendRef(&backendRef); err != nil {
r.log.Error(err, "invalid backendRef")
continue
}
Expand Down Expand Up @@ -467,8 +466,7 @@ func (r *gatewayAPIReconciler) processTCPRoutes(ctx context.Context, gatewayName

for _, rule := range tcpRoute.Spec.Rules {
for _, backendRef := range rule.BackendRefs {
ref := gatewayapi.UpgradeBackendRef(backendRef)
if err := validateBackendRef(&ref); err != nil {
if err := validateBackendRef(&backendRef); err != nil {
r.log.Error(err, "invalid backendRef")
continue
}
Expand Down Expand Up @@ -545,8 +543,7 @@ func (r *gatewayAPIReconciler) processUDPRoutes(ctx context.Context, gatewayName

for _, rule := range udpRoute.Spec.Rules {
for _, backendRef := range rule.BackendRefs {
ref := gatewayapi.UpgradeBackendRef(backendRef)
if err := validateBackendRef(&ref); err != nil {
if err := validateBackendRef(&backendRef); err != nil {
r.log.Error(err, "invalid backendRef")
continue
}
Expand Down