Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up gatewayapi v1alpha2 helpers #4482

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Oct 19, 2024

What type of PR is this?

What this PR does / why we need it:

gwapiv1a2.BackendRef is an alias for gwapiv1.BackendRef

Which issue(s) this PR fixes:

Fixes #

@shawnh2 shawnh2 requested a review from a team as a code owner October 19, 2024 06:22
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.84%. Comparing base (26ec49a) to head (8c793b3).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/routes.go 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4482   +/-   ##
=======================================
  Coverage   65.83%   65.84%           
=======================================
  Files         203      202    -1     
  Lines       30699    30678   -21     
=======================================
- Hits        20212    20200   -12     
+ Misses       9335     9323   -12     
- Partials     1152     1155    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2
Copy link
Contributor Author

shawnh2 commented Oct 21, 2024

/retest

@zirain zirain merged commit deddeb4 into envoyproxy:main Oct 21, 2024
25 of 26 checks passed
@shawnh2 shawnh2 deleted the clean-gwapiv1a2 branch October 22, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants