feat: add labels to envoyService config #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jukie <[email protected]>
zetaab
approved these changes
Oct 12, 2024
|
ah actually you need to generate crds again. could you run |
Signed-off-by: jukie <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4427 +/- ##
==========================================
+ Coverage 65.81% 65.82% +0.01%
==========================================
Files 200 200
Lines 24171 24177 +6
==========================================
+ Hits 15907 15915 +8
+ Misses 7129 7127 -2
Partials 1135 1135 ☔ View full report in Codecov by Sentry. |
zetaab
approved these changes
Oct 12, 2024
|
/retest |
zirain
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: add labels to envoyService config
What this PR does / why we need it:
This adds the ability to configure labels that should specifically be applied to the service within an EnvoyProxy spec. This is useful for doing things like selecting a cilium IP pool or other labels that a user doesn't want to be applied to all related resources via the existing infra labels option.
Which issue(s) this PR fixes:
Fixes #4417