Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support labels configuration in EnvoyProxy spec #4417

Closed
jukie opened this issue Oct 9, 2024 · 3 comments · Fixed by #4427
Closed

Support labels configuration in EnvoyProxy spec #4417

jukie opened this issue Oct 9, 2024 · 3 comments · Fixed by #4427
Assignees
Labels
area/api API-related issues area/provider
Milestone

Comments

@jukie
Copy link
Contributor

jukie commented Oct 9, 2024

Description:
I'd like the ability to configure labels on the envoyService spec within the EnvoyProxy resource so that I can do things like target a specific cilium IP pool.

Would it be accepted if I made this change in KubernetesServiceSpec?

type KubernetesServiceSpec struct {

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@jukie jukie added the triage label Oct 9, 2024
@zetaab
Copy link
Contributor

zetaab commented Oct 9, 2024

@jukie see https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1/gateway_types.go#L722 it might be that these are supported already using Gateway crd

@jukie
Copy link
Contributor Author

jukie commented Oct 9, 2024

I may be doing something wrong but labels added there are not applied to the service backing the gateway. I was doing something wrong, this does work!

But that also wouldn't allow for more granular labels that should only be applied to the service.

@arkodg arkodg added help wanted Extra attention is needed area/api API-related issues and removed triage labels Oct 10, 2024
@arkodg arkodg added this to the Backlog milestone Oct 10, 2024
@arkodg
Copy link
Contributor

arkodg commented Oct 10, 2024

sounds like a valid use case, assigning this to you @jukie, thanks !

@arkodg arkodg removed the help wanted Extra attention is needed label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API-related issues area/provider
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants