chore: update grafana dashboards #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3746 +/- ##
==========================================
- Coverage 69.05% 69.00% -0.06%
==========================================
Files 176 176
Lines 21751 21751
==========================================
- Hits 15021 15010 -11
- Misses 5652 5661 +9
- Partials 1078 1080 +2 ☔ View full report in Codecov by Sentry. |
|
can you try to refactor dashboard with https://github.com/istio/istio/blob/395b9bb706a4fcb8633beac188b64707d7e7a1f1/manifests/addons/dashboards/README.md to make it maintainable? |
this may require a lot of refactor work, raise another issue to track it. |
zirain
approved these changes
Jul 5, 2024
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
follow-up of #3727, fix #3703