Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export WASM metrics into Grafana dashboard #3703

Closed
shawnh2 opened this issue Jun 29, 2024 · 0 comments · Fixed by #3746
Closed

Export WASM metrics into Grafana dashboard #3703

shawnh2 opened this issue Jun 29, 2024 · 0 comments · Fixed by #3746
Assignees
@shawnh2
Labels
area/observability Observability related issues

Comments

@shawnh2
Copy link
Contributor

shawnh2 commented Jun 29, 2024 •
edited
Loading

Description:

Describe the issue.

Export WASM metrics (https://github.com/envoyproxy/gateway/blob/main/internal/wasm/metrics.go) into Grafana dashboard (https://github.com/envoyproxy/gateway/blob/main/charts/gateway-addons-helm/dashboards/envoy-gateway-global.json) by adding a new row in that dashboard.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

remove TODO in

gateway/internal/wasm/metrics.go

Line 54 in 51c6eb4

// TODO zhaohuabing export metrics to control plane dashboard.

@shawnh2 shawnh2 added triage area/observability Observability related issues help wanted Extra attention is needed and removed triage labels Jun 29, 2024
@shawnh2 shawnh2 self-assigned this Jul 4, 2024
@shawnh2 shawnh2 removed the help wanted Extra attention is needed label Jul 4, 2024
@shawnh2 shawnh2 mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnh2 shawnh2

Labels
area/observability Observability related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update grafana dashboards shawnh2/gateway
1 participant
@shawnh2