-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: support for external authz #2435
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2435 +/- ##
=======================================
Coverage 64.63% 64.63%
=======================================
Files 116 116
Lines 17797 17797
=======================================
Hits 11503 11503
Misses 5558 5558
Partials 736 736 ☔ View full report in Codecov by Sentry. |
0362885
to
5eb3bb7
Compare
Signed-off-by: huabing zhao <[email protected]>
5eb3bb7
to
f9857e2
Compare
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]> Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
@zhaohuabing can you link the envoy config that the tls config here will be translated into for |
The The For gRPC service, the cluster is specified in |
awesome thanks @zhaohuabing ! I brought this up to bring up a common question around proxy identity, do we want to support a unique key/cert for
or should we reuse listener/downstream certs ? |
Envoy docs says that Only a single TLS certificate is supported in client contexts tls_certificates We can reuse this for JWT as well. |
Signed-off-by: huabing zhao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
Signed-off-by: Huabing Zhao <[email protected]>
External authorization API.
Related: #1059