External Authorization #2392
External Authorization #2392
Conversation
Signed-off-by: huabing zhao <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2392 +/- ##
==========================================
- Coverage 64.64% 64.59% -0.05%
==========================================
Files 114 115 +1
Lines 16618 16858 +240
==========================================
+ Hits 10742 10889 +147
- Misses 5197 5265 +68
- Partials 679 704 +25 ☔ View full report in Codecov by Sentry. |
Signed-off-by: huabing zhao <[email protected]>
| } | ||
|
|
||
| // TLSConfig describes a TLS configuration. | ||
| type TLSConfig struct { |
There was a problem hiding this comment.
This can be used for other external services as well, e.g, jwt providers.
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
force-pushed
the
ext_authz
branch
from
b842d63 to
59fbbfc
Compare
Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
force-pushed
the
ext_authz
branch
from
59fbbfc to
d2fae5a
Compare
| // TLS defines the TLS configuration for the gRPC External Authorization service. | ||
| // Note: If not specified, the proxy will talk to the gRPC External | ||
| // Authorization service in plaintext. | ||
| TLS *TLSConfig `json:"tlsSettings,omitempty" yaml:"tlsSettings"` |
There was a problem hiding this comment.
The existence of TLS indicates that the Envoy should talk to the GRPC service with tls.
| ) | ||
|
|
||
| // ExtAuth defines the configuration for External Authorization. | ||
| type ExtAuth struct { |
There was a problem hiding this comment.
@arkodg @envoyproxy/gateway-maintainers Could you please take a look at the ext auth API? I'd like to reach agreement on the API before moving forward with this
There was a problem hiding this comment.
can you open an API only PR so that PR can be marked as ready and can be reviewed by others as well ? tia
|
Close this one because the commit history is a bit messy and it's hard to rebase/merge. |
This PR continues the work by @akhenakh in #2313 to add per-route external authorization support.
Related: #1059