Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more tests in experimental conformance profile report #2056

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Oct 24, 2023

No description provided.

@arkodg arkodg requested a review from a team as a code owner October 24, 2023 00:17
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2056 (ab8ebc8) into main (fdcd9e4) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
- Coverage   65.32%   65.20%   -0.12%     
==========================================
  Files          99       99              
  Lines       14640    14640              
==========================================
- Hits         9563     9546      -17     
- Misses       4493     4508      +15     
- Partials      584      586       +2     

see 2 files with indirect coverage changes

@arkodg
Copy link
Contributor Author

arkodg commented Oct 24, 2023

something is broken in the conformance framework, ive disabled the mesh feature, but the tests still run
cc @Xunzhuo

@Xunzhuo
Copy link
Member

Xunzhuo commented Oct 24, 2023

This is sn upstream bug. I manually remove them before. The current way is already included all tests except skip tests.

@arkodg
Copy link
Contributor Author

arkodg commented Oct 24, 2023

blocked on kubernetes-sigs/gateway-api#2515

@arkodg
Copy link
Contributor Author

arkodg commented Oct 26, 2023

hey @Xunzhuo where's the report artifact :) ?

@arkodg arkodg requested review from a team, kflynn, qicz and LanceEa and removed request for a team October 26, 2023 02:59
@Xunzhuo
Copy link
Member

Xunzhuo commented Oct 26, 2023

@arkodg
Copy link
Contributor Author

arkodg commented Oct 26, 2023

thanks
looks like we should work on enabling the skipped tests before v0.6

apiVersion: gateway.networking.k8s.io/v1alpha1
date: "2023-10-26T02:53:47Z"
gatewayAPIVersion: TODO
implementation:
  contact:
  - https://github.com/envoyproxy/gateway/blob/main/GOVERNANCE.md
  organization: envoyproxy
  project: envoy-gateway
  url: https://github.com/envoyproxy/gateway
  version: latest
kind: ConformanceReport
profiles:
- core:
    result: partial
    skippedTests:
    - GatewaySecretInvalidReferenceGrant
    statistics:
      Failed: 0
      Passed: 9
      Skipped: 1
    summary: ""
  name: TLS
- core:
    result: partial
    skippedTests:
    - GatewaySecretInvalidReferenceGrant
    - GatewayWithAttachedRoutes
    statistics:
      Failed: 0
      Passed: 27
      Skipped: 2
    summary: ""
  extended:
    result: partial
    skippedTests:
    - HTTPRouteRewritePath
    statistics:
      Failed: 0
      Passed: 11
      Skipped: 1
    summary: ""
    supportedFeatures:
    - HTTPRoutePortRedirect
    - HTTPRoutePathRedirect
    - HTTPRouteRequestTimeout
    - HTTPRouteQueryParamMatching
    - HTTPRouteRequestMultipleMirrors
    - HTTPRoutePathRewrite
    - HTTPRouteBackendTimeout
    - HTTPRouteSchemeRedirect
    - HTTPRouteHostRewrite
    - HTTPRouteRequestMirror
    - HTTPRouteMethodMatching
    - HTTPRouteResponseHeaderModification
  name: HTTP

@Xunzhuo Xunzhuo merged commit 608ddd3 into envoyproxy:main Oct 26, 2023
21 checks passed
@arkodg arkodg deleted the run-mo-tests branch October 26, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants