Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CORS ir and xds translation #2016

Merged
merged 2 commits into from
Oct 22, 2023

Remove AllowPrivateNetworkAccess since it's not a common knob

fa3b523
Select commit
Loading
Failed to load commit list.
Merged

feat: CORS ir and xds translation #2016

Remove AllowPrivateNetworkAccess since it's not a common knob
fa3b523
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 22, 2023 in 1s

65.36% (target 60.00%)

View this Pull Request on Codecov

65.36% (target 60.00%)

Details

Codecov Report

Merging #2016 (fa3b523) into main (c59ced0) will increase coverage by 0.03%.
The diff coverage is 55.92%.

@@            Coverage Diff             @@
##             main    #2016      +/-   ##
==========================================
+ Coverage   65.33%   65.36%   +0.03%     
==========================================
  Files          93       95       +2     
  Lines       13727    13929     +202     
==========================================
+ Hits         8968     9105     +137     
- Misses       4205     4259      +54     
- Partials      554      565      +11     
Files Coverage Δ
internal/ir/xds.go 74.10% <ø> (ø)
internal/xds/translator/listener.go 82.64% <0.00%> (-0.22%) ⬇️
internal/xds/translator/route.go 92.14% <0.00%> (+0.97%) ⬆️
internal/xds/translator/httpfilters.go 78.26% <78.26%> (ø)
internal/xds/translator/cors.go 65.97% <65.97%> (ø)
internal/ir/zz_generated.deepcopy.go 11.97% <0.00%> (-0.56%) ⬇️

... and 2 files with indirect coverage changes