feat: CORS ir and xds translation #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
force-pushed
the
xds-ir-cors
branch
2 times, most recently
from
57e53c5 to
40e41fe
Compare
Codecov Report
@@ Coverage Diff @@
## main #2016 +/- ##
==========================================
+ Coverage 65.33% 65.36% +0.03%
==========================================
Files 93 95 +2
Lines 13727 13929 +202
==========================================
+ Hits 8968 9105 +137
- Misses 4205 4259 +54
- Partials 554 565 +11
|
zhaohuabing
force-pushed
the
xds-ir-cors
branch
2 times, most recently
from
2466e33 to
51517c5
Compare
arkodg
reviewed
Oct 19, 2023
arkodg
reviewed
Oct 19, 2023
arkodg
reviewed
Oct 19, 2023
arkodg
reviewed
Oct 19, 2023
arkodg
reviewed
Oct 19, 2023
arkodg
reviewed
Oct 19, 2023
|
thanks for picking this one up @zhaohuabing, added some minor comments |
zhaohuabing
force-pushed
the
xds-ir-cors
branch
from
56f28bf to
959bbc9
Compare
zhaohuabing
force-pushed
the
xds-ir-cors
branch
4 times, most recently
from
0bdc33d to
1d7f30f
Compare
zhaohuabing
force-pushed
the
xds-ir-cors
branch
from
1d7f30f to
7e09ffc
Compare
zhaohuabing
requested review from
a team,
kflynn,
Alice-Lilith and
Xunzhuo
and removed request for
a team
zhaohuabing
force-pushed
the
xds-ir-cors
branch
from
0128bd7 to
80fb42b
Compare
arkodg
reviewed
Oct 20, 2023
arkodg
reviewed
Oct 20, 2023
arkodg
reviewed
Oct 20, 2023
zhaohuabing
force-pushed
the
xds-ir-cors
branch
2 times, most recently
from
596400e to
b8fc9d7
Compare
zhaohuabing
force-pushed
the
xds-ir-cors
branch
from
a1e970a to
0fdb6d0
Compare
Signed-off-by: huabing zhao <[email protected]> sort HTTP filters Signed-off-by: huabing zhao <[email protected]> address comments Signed-off-by: huabing zhao <[email protected]> refactor route filter config Signed-off-by: huabing zhao <[email protected]> address comments Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
force-pushed
the
xds-ir-cors
branch
from
0fdb6d0 to
fa3b523
Compare
zirain
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Adds ir and xds translation for CORS.
The CORS will be part of the SecurityPolicy API. The API and translation to ir will be included in a subsequent PR after the SecurityPolicy PR has been completed.
Sorts the HTTP filter in a rational order after patching all filters to the HCM filter chain, so each individual filter translator doesn't have to care about its own order anymore.
Relates to #567