Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint Slice support for ServiceImport #1947

Merged
merged 2 commits into from
Oct 13, 2023

addressed review comments

6c3ca09
Select commit
Loading
Failed to load commit list.
Merged

Endpoint Slice support for ServiceImport #1947

addressed review comments
6c3ca09
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Oct 12, 2023 in 0s

65.36% (target 60.00%)

View this Pull Request on Codecov

65.36% (target 60.00%)

Details

Codecov Report

Merging #1947 (6c3ca09) into main (76704d1) will decrease coverage by 0.08%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main    #1947      +/-   ##
==========================================
- Coverage   65.43%   65.36%   -0.08%     
==========================================
  Files          90       90              
  Lines       13367    13386      +19     
==========================================
+ Hits         8747     8750       +3     
- Misses       4083     4095      +12     
- Partials      537      541       +4     
Files Coverage Δ
internal/gatewayapi/resource.go 67.27% <100.00%> (+4.00%) ⬆️
internal/gatewayapi/route.go 87.38% <77.77%> (-0.75%) ⬇️

... and 3 files with indirect coverage changes