Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint Slice support for ServiceImport #1947

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

tanujd11
Copy link
Member

What type of PR is this?

Feature: Multicluster services API

What this PR does / why we need it:

With #1494 EndpointSlice support is added for backends for gateway. This PR do the same for ServiceImport.

Which issue(s) this PR fixes:

Fixes #1908

@tanujd11 tanujd11 requested a review from a team as a code owner October 10, 2023 18:37
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1947 (6c3ca09) into main (76704d1) will decrease coverage by 0.08%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main    #1947      +/-   ##
==========================================
- Coverage   65.43%   65.36%   -0.08%     
==========================================
  Files          90       90              
  Lines       13367    13386      +19     
==========================================
+ Hits         8747     8750       +3     
- Misses       4083     4095      +12     
- Partials      537      541       +4     
Files Coverage Δ
internal/gatewayapi/resource.go 67.27% <100.00%> (+4.00%) ⬆️
internal/gatewayapi/route.go 87.38% <77.77%> (-0.75%) ⬇️

... and 3 files with indirect coverage changes

@tanujd11 tanujd11 force-pushed the feat/ep-slice-in-mcs branch from 7541565 to 4bbc5b1 Compare October 12, 2023 12:13
@tanujd11 tanujd11 force-pushed the feat/ep-slice-in-mcs branch from 4bbc5b1 to 6c3ca09 Compare October 12, 2023 12:16
@tanujd11
Copy link
Member Author

/retest

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team, kflynn, zhaohuabing and qicz and removed request for a team October 12, 2023 19:51
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job!

@arkodg arkodg merged commit 2ecc54d into envoyproxy:main Oct 13, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EndpointSlice for ServiceImport
3 participants