-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint Slice support for ServiceImport #1947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1947 +/- ##
==========================================
- Coverage 65.43% 65.36% -0.08%
==========================================
Files 90 90
Lines 13367 13386 +19
==========================================
+ Hits 8747 8750 +3
- Misses 4083 4095 +12
- Partials 537 541 +4
|
arkodg
reviewed
Oct 10, 2023
arkodg
reviewed
Oct 10, 2023
Signed-off-by: tanujd11 <[email protected]>
tanujd11
force-pushed
the
feat/ep-slice-in-mcs
branch
from
October 12, 2023 12:13
7541565
to
4bbc5b1
Compare
Signed-off-by: tanujd11 <[email protected]>
tanujd11
force-pushed
the
feat/ep-slice-in-mcs
branch
from
October 12, 2023 12:16
4bbc5b1
to
6c3ca09
Compare
/retest |
arkodg
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
arkodg
requested review from
a team,
kflynn,
zhaohuabing and
qicz
and removed request for
a team
October 12, 2023 19:51
zhaohuabing
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature: Multicluster services API
What this PR does / why we need it:
With #1494 EndpointSlice support is added for backends for gateway. This PR do the same for ServiceImport.
Which issue(s) this PR fixes:
Fixes #1908