kafka: 2.4.0 support - add support for new data types added in 2.4 #9813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkotwasinski
changed the title
adamkotwasinski
force-pushed
the
kafka
branch
from
a1fe3c1
to
2f0d1a9
Compare
…egers, compact strings, compact bytes, compact arrays Signed-off-by: Adam Kotwasinski <[email protected]>
Signed-off-by: Adam Kotwasinski <[email protected]>
Signed-off-by: Adam Kotwasinski <[email protected]>
adamkotwasinski
force-pushed
the
kafka
branch
from
2f0d1a9
to
862482c
Compare
adamkotwasinski
changed the title
Signed-off-by: Adam Kotwasinski <[email protected]>
Signed-off-by: Adam Kotwasinski <[email protected]>
Signed-off-by: Adam Kotwasinski <[email protected]>
Signed-off-by: Adam Kotwasinski <[email protected]>
|
@adamkotwasinski are you waiting on a review here, or still iterating? |
|
@junr03 still iterating, didn't expect that build failure! |
…variable-length uint deserializer Signed-off-by: Adam Kotwasinski <[email protected]>
Signed-off-by: Adam Kotwasinski <[email protected]>
Signed-off-by: Adam Kotwasinski <[email protected]>
|
/wait-any |
adamkotwasinski
changed the title
adamkotwasinski
changed the title
|
This PR should not have any impact on existing Kafka protocol coverage, as the new classes are not yet referenced from (generated) requests.h / responses.h protocol files. It can be noticed that there's some duplication here, as we are handling very similar data types all the time (e.g. (nullable) (compact) byte array). I will want to revisit this place to refactor it later, to avoid PR noise. /assign @mattklein123 |
mattklein123
approved these changes
Feb 10, 2020
|
@adamkotwasinski will the dependency updates come in a follow up PR? |
|
@moderation yes - when I'm done with #10000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Provide codec support for data types added in 2.4.0.
In detail, we Kafka 2.4 added some new things in protocol:
This PR should not have any impact on existing codebase, just the volume of changes (if everything was posted at once) is IMHO too large to comfortably review.
Relates to #2852
These deserializers are working with 2.4 request types (they are not part of this PR as I'm still working on that and want to make another PR with them).
Risk Level: Low
Testing: Automated unit tests; embedded integration test (ensures compatibility with 2.3 client); manual tests with 2.3 client
Docs Changes: N/A
Release Notes: N/A