-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kafka: 2.4.0 support - add support for new message types added in 2.4 #10000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkotwasinski
force-pushed
the
kafka
branch
from
February 11, 2020 00:47
e9a54cb
to
f4ffe57
Compare
adamkotwasinski
force-pushed
the
kafka
branch
from
February 11, 2020 01:04
f4ffe57
to
5d353f8
Compare
adamkotwasinski
force-pushed
the
kafka
branch
from
February 11, 2020 01:20
5d353f8
to
339f1e2
Compare
adamkotwasinski
force-pushed
the
kafka
branch
from
February 11, 2020 01:27
339f1e2
to
7e502ff
Compare
adamkotwasinski
force-pushed
the
kafka
branch
from
February 13, 2020 01:06
7e502ff
to
70ac15b
Compare
adamkotwasinski
force-pushed
the
kafka
branch
from
February 13, 2020 20:02
70ac15b
to
46f3761
Compare
Signed-off-by: Adam Kotwasinski <[email protected]>
Signed-off-by: Adam Kotwasinski <[email protected]>
…essages that use flexible versioning Signed-off-by: Adam Kotwasinski <[email protected]>
…w compact types Signed-off-by: Adam Kotwasinski <[email protected]>
…header responsible for its own serialization Signed-off-by: Adam Kotwasinski <[email protected]>
…e header responsible for its own serialization Signed-off-by: Adam Kotwasinski <[email protected]>
…d code; comments Signed-off-by: Adam Kotwasinski <[email protected]>
adamkotwasinski
force-pushed
the
kafka
branch
from
February 13, 2020 22:36
46f3761
to
2bc284c
Compare
…date int test zookeeper config; update documentation Signed-off-by: Adam Kotwasinski <[email protected]>
adamkotwasinski
force-pushed
the
kafka
branch
from
February 13, 2020 23:16
2bc284c
to
58aff58
Compare
adamkotwasinski
changed the title
[WIP] kafka: 2.4.0 support - add support for new message types added in 2.4
kafka: 2.4.0 support - add support for new message types added in 2.4
Feb 14, 2020
/assign @mattklein123 @moderation |
mattklein123
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Provide Kafka codec support for new message types/versions added in 2.4.0.
In detail, we Kafka 2.4 added some new things in protocol:
This PR does the following:
This PR relates to #2852
Risk Level: Low
Testing: Automated unit tests; embedded integration test (ensures compatibility with 2.4 client); manual tests with Java Kafka 1.1 / 2.3 / 2.4 clients + 2.1 / 2.3 / 2.4 servers
Docs Changes: docs reference changed from 2.3 to 2.4 :)
Release Notes: N/A