Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: 2.4.0 support - add support for new message types added in 2.4 #10000

Merged
merged 8 commits into from
Feb 14, 2020

Conversation

adamkotwasinski
Copy link
Contributor

@adamkotwasinski adamkotwasinski commented Feb 10, 2020

Description:
Provide Kafka codec support for new message types/versions added in 2.4.0.

In detail, we Kafka 2.4 added some new things in protocol:

This PR does the following:

  • update the python-generator script (as the input format has changed a little - we have "common structs" and "tag references")
  • update the request / response parsers - we need to process tagged fields that might be present in headers (this depends on message's api_key & api_version)

This PR relates to #2852

Risk Level: Low
Testing: Automated unit tests; embedded integration test (ensures compatibility with 2.4 client); manual tests with Java Kafka 1.1 / 2.3 / 2.4 clients + 2.1 / 2.3 / 2.4 servers
Docs Changes: docs reference changed from 2.3 to 2.4 :)
Release Notes: N/A

Signed-off-by: Adam Kotwasinski <[email protected]>
…essages that use flexible versioning

Signed-off-by: Adam Kotwasinski <[email protected]>
…header responsible for its own serialization

Signed-off-by: Adam Kotwasinski <[email protected]>
…e header responsible for its own serialization

Signed-off-by: Adam Kotwasinski <[email protected]>
…date int test zookeeper config; update documentation

Signed-off-by: Adam Kotwasinski <[email protected]>
@adamkotwasinski adamkotwasinski changed the title [WIP] kafka: 2.4.0 support - add support for new message types added in 2.4 kafka: 2.4.0 support - add support for new message types added in 2.4 Feb 14, 2020
@adamkotwasinski adamkotwasinski marked this pull request as ready for review February 14, 2020 03:52
@adamkotwasinski
Copy link
Contributor Author

/assign @mattklein123 @moderation

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mattklein123 mattklein123 merged commit bbf365b into envoyproxy:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants