Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: fix quic_test_server_test #32755

Merged
merged 2 commits into from
Mar 7, 2024

format

b668a2d
Select commit
Loading
Failed to load commit list.
Merged

mobile: fix quic_test_server_test #32755

format
b668a2d
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Envoy/Publish and verify skipped Mar 6, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/32755/main@b668a2d)

danzh2010 @danzh2010 b668a2d #32755 merge main@a19dce3

mobile: fix quic_test_server_test

Commit Message: the test failed after #32260 because the test server uses a mocked MockTransportSocketFactoryContext which doesn't return a real ContextManager object in sslContextManager(). The mocked object returns nullptr in createSslServerContext(), thus fail to initialize the new member ssl_ctx_ in QuicServerTransportSocketFactory.

Additional Description: bazel test //test/java/io/envoyproxy/envoymobile/engine/testing:quic_test_server_test passes in this PR
Risk Level: low, test only
Testing: existing tests pass
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Environment

Request variables

Key Value
ref 685aa436ae51b40cd353bcf694482ce157a153ad
sha b668a2d
pr 32755
base-sha a19dce3
actor danzh2010 @danzh2010
message mobile: fix quic_test_server_test...
started 1709768386.79198
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:0ca52447572ee105a4730da5e76fe47c9c5a7c64
mobile envoyproxy/envoy-build-ubuntu:mobile-0ca52447572ee105a4730da5e76fe47c9c5a7c64
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 30
patch 0
dev true