mobile: fix quic_test_server_test #32755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Zhang <[email protected]>
danzh2010
requested review from
RyanTheOptimist,
alyssawilk and
abeyad
as code owners
RyanTheOptimist
previously approved these changes
Mar 6, 2024
Signed-off-by: Dan Zhang <[email protected]>
RyanTheOptimist
approved these changes
Mar 7, 2024
mattjo
added a commit
to mattjo/envoy
that referenced
this pull request
Mar 7, 2024
* origin: mobile: Clean up Java and Kotlin code (envoyproxy#32773) [mobile] Increase stream response buffer watermark size to 2MB (envoyproxy#32754) oauth2: support disabling redirects for AJAX requests (envoyproxy#32655) http2: Switch the value of envoy.reloadable_features.http2_use_oghttp2 to false (envoyproxy#32751) envoy: reverting unnecessary exception E-M macros (envoyproxy#32745) dfp: reverting 31433 (envoyproxy#32743) opentelemetrytracer: Allow sampler to set variant type span attribute… (envoyproxy#32681) mobile: Java code cleanup (envoyproxy#32747) mobile: fix quic_test_server_test (envoyproxy#32755) Common TunnelResponseHeadersOrTrailers for UDP & TCP tunneling (envoyproxy#32619)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: the test failed after #32260 because the test server uses a mocked MockTransportSocketFactoryContext which doesn't return a real ContextManager object in sslContextManager(). The mocked object returns nullptr in createSslServerContext(), thus fail to initialize the new member ssl_ctx_ in QuicServerTransportSocketFactory.
Additional Description: bazel test //test/java/io/envoyproxy/envoymobile/engine/testing:quic_test_server_test passes in this PR
Risk Level: low, test only
Testing: existing tests pass
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A