[bp/1.29] Not crash envoy when env resource detector can't detect attributes #32299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor can't detect attributes (envoyproxy#32229) Signed-off-by: Joao Grassi <[email protected]>
|
@joaopgrassi is 1.29 the earliest branch requiring the fix ? |
phlax
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
lgtm, thanks @joaopgrassi
just in time for pending release!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @wbpcode I'm creating this backport to 1.29 for this bug. We just merged this feature in Istio and would be great if this can be ported, so maybe the current to be release Istio version can have this.
Commit Message: Backport from #32229
Additional Description:
Risk Level: Low
Testing: Unit, Integration and Manual
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]