opentelemetry tracer: Not crash envoy when environment resource detector can't detect attributes #32229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joao Grassi <[email protected]>
|
CC @wbpcode as we discussed offline. |
wbpcode
reviewed
Feb 7, 2024
...nsions/tracers/opentelemetry/resource_detectors/environment/environment_resource_detector.cc
Show resolved
Hide resolved
|
/retest |
|
/wait add warning log |
Signed-off-by: Joao Grassi <[email protected]>
This was referenced Feb 8, 2024
joaopgrassi
added a commit
to dynatrace-oss-contrib/envoy
that referenced
this pull request
Feb 9, 2024
…tor can't detect attributes (envoyproxy#32229) Signed-off-by: Joao Grassi <[email protected]>
phlax
pushed a commit
that referenced
this pull request
Feb 9, 2024
…tor can't detect attributes (#32229) Signed-off-by: Joao Grassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Not crash envoy when env resource detector can't detect attributes
Additional Description:
Risk Level: Low
Testing: Unit/Integration/Manual
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #32225]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]