SDS: reduce cost of secret update #19971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
lambdai
requested review from
mattklein123,
alyssawilk,
lizan and
ggreenway
as code owners
Signed-off-by: Yuchen Dai <[email protected]>
yanavlasov
requested changes
Feb 16, 2022
source/extensions/transport_sockets/tls/context_manager_impl.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Yuchen Dai <[email protected]>
yanavlasov
previously approved these changes
Feb 16, 2022
ggreenway
requested changes
Feb 16, 2022
source/extensions/transport_sockets/tls/context_manager_impl.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Yuchen Dai <[email protected]>
ggreenway
approved these changes
Feb 16, 2022
ggreenway
previously requested changes
Feb 16, 2022
|
@ggreenway add an item in minor behavior change |
Signed-off-by: Yuchen Dai <[email protected]>
auto-merge was automatically disabled
February 17, 2022 00:00
Head branch was pushed to by a user without write access
yanavlasov
previously approved these changes
Feb 17, 2022
Signed-off-by: Yuchen Dai <[email protected]>
auto-merge was automatically disabled
February 17, 2022 05:42
Head branch was pushed to by a user without write access
lambdai
commented
Feb 17, 2022
yanavlasov
approved these changes
Feb 17, 2022
|
/backport I am happy to create the PRs if it is approved |
repokitteh-read-only
bot
added
the
backport/review
CC @oschaaf for approval |
|
@lambdai I have no objections if @ggreenway or @yanavlasov would be up for reviewing the backports. |
lambdai
added a commit
to lambdai/envoy-dai
that referenced
this pull request
Mar 2, 2022
Signed-off-by: Yuchen Dai <[email protected]>
lambdai
added a commit
to lambdai/envoy-dai
that referenced
this pull request
Mar 3, 2022
Signed-off-by: Yuchen Dai <[email protected]>
lambdai
added a commit
to lambdai/envoy-dai
that referenced
this pull request
Mar 3, 2022
Signed-off-by: Yuchen Dai <[email protected]>
lambdai
added a commit
to lambdai/envoy-dai
that referenced
this pull request
Mar 3, 2022
Signed-off-by: Yuchen Dai <[email protected]>
This was referenced Mar 3, 2022
ggreenway
pushed a commit
that referenced
this pull request
Mar 9, 2022
Signed-off-by: Yuchen Dai <[email protected]>
ggreenway
pushed a commit
that referenced
this pull request
Mar 15, 2022
Backport of #19971 Signed-off-by: Yuchen Dai <[email protected]>
alyssawilk
pushed a commit
that referenced
this pull request
Mar 28, 2022
Commit Message: Backport #19971 Signed-off-by: Yuchen Dai [email protected] Signed-off-by: Yuchen Dai <[email protected]>
lambdai
commented
May 25, 2022
| config_->setSecretUpdateCallback([this]() { onAddOrUpdateSecret(); }); | ||
| } | ||
|
|
||
| ClientSslSocketFactory::~ClientSslSocketFactory() { manager_.removeContext(ssl_ctx_); } |
There was a problem hiding this comment.
manager_ could be a dangling reference when Envoy shuts down
There was a problem hiding this comment.
Can you create a test that fails in ASAN for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Previously the SSL context manager scans the maintained list of context weak_ptr at any context update.
In this PR, the role of the maintenance moved to prod ClientSslSocketFactory and ServerSslSocketFactory.
The prod SSL context manager can then switch to shared_ptr from weak_ptr.
The shared_ptr can be put into hash set container and no list scan is needed.
This PR also move the context construction and destroy out of the critical contention.
Additional Description:
Risk Level: LOW
Testing: existing integration test, and updated unit test cases that bypassing the SslSocketFactory
Docs Changes:
Release Notes:
Fix #19774