Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager_ could be a dangling reference when Envoy shuts down #21447

Closed
lambdai opened this issue May 25, 2022 · 5 comments · Fixed by #23452
Closed

manager_ could be a dangling reference when Envoy shuts down #21447

lambdai opened this issue May 25, 2022 · 5 comments · Fixed by #23452
Assignees

Comments

@lambdai
Copy link
Contributor

lambdai commented May 25, 2022

Thank @JuniorHsu for reporting a crash.

manager_ could be a dangling reference when Envoy shuts down

Originally posted by @lambdai in #19971 (comment)

@lambdai
Copy link
Contributor Author

lambdai commented May 25, 2022

/assign lambdai

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 25, 2022
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as completed Jul 2, 2022
@JuniorHsu
Copy link
Contributor

this occurs again.

@kyessenov kyessenov reopened this Oct 12, 2022
@kyessenov kyessenov assigned kyessenov and unassigned lambdai Oct 12, 2022
@kyessenov
Copy link
Contributor

This is quite convoluted. I think the remaining bit of information missing is #14954. That PR modified the destructor of ClusterInfo which owns the last SSL socket context to be dispatched and deleted on the main thread. So it should be easy to delay manager_ destruction after dispatcher_ to fix this crash.

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants