Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to Dockerhub release tagging #1777

Merged
merged 2 commits into from
Sep 29, 2017
Merged

Fixes to Dockerhub release tagging #1777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bade346
Install Docker in tag script
bndw Sep 29, 2017
6785a7d
Skip build/test for tag events
bndw Sep 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ci/do_circle_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

set -e

if [ -n "$CIRCLE_TAG" ]
then
echo 'Ignoring build for git tag event'
exit 0
fi

# bazel uses jgit internally and the default circle-ci .gitconfig says to
# convert https://github.com to ssh://[email protected], which jgit does not support.
mv ~/.gitconfig ~/.gitconfig_save
Expand Down
10 changes: 10 additions & 0 deletions ci/docker_tag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@ set -e

if [ -n "$CIRCLE_TAG" ]
then
# TODO(mattklein123): Currently we are doing this push in the context of the release job which
# happens inside of our build image. We should switch to using Circle caching so each of these
# are discrete jobs that work with the binary. All of these commands run on a remote docker
# server also so we have to temporarily install docker here.
# https://circleci.com/docs/2.0/building-docker-images/
VER="17.03.0-ce"
curl -L -o /tmp/docker-"$VER".tgz https://get.docker.com/builds/Linux/x86_64/docker-"$VER".tgz
tar -xz -C /tmp -f /tmp/docker-"$VER".tgz
mv /tmp/docker/* /usr/bin

docker login -u "$DOCKERHUB_USERNAME" -p "$DOCKERHUB_PASSWORD"

docker pull lyft/envoy:"$CIRCLE_SHA1"
Expand Down