Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to Dockerhub release tagging #1777

Merged
merged 2 commits into from
Sep 29, 2017
Merged

Fixes to Dockerhub release tagging #1777

merged 2 commits into from
Sep 29, 2017

Conversation

bndw
Copy link
Contributor

@bndw bndw commented Sep 29, 2017 •
edited
Loading

This is a follow up to #1768

  • Resolves missing docker command by installing Docker in tag script (CI failure)
  • Skips unnecessary build/test on tag events

mattklein123
mattklein123 approved these changes Sep 29, 2017
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks. Will try another tag after this builds on master.

@mattklein123 mattklein123 merged commit 7789c5d into envoyproxy:master Sep 29, 2017
@bndw bndw deleted the tag-fixes branch September 29, 2017 03:08
costinm pushed a commit to costinm/envoy that referenced this pull request Oct 2, 2017
@bndw @costinm
Fixes to Dockerhub release tagging (envoyproxy#1777)
5e6b5b0 
Signed-off-by: bndw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bndw @mattklein123