Add direct dependencies on fmtlib for fmt::format #1579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t dependency in multiple header files
…t dependency in multiple header files
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Changing envoy mobile to preserve header casing for HTTP/1.1 header keys Risk Level: Medium Testing: new integration test Part of #1558 Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Changing envoy mobile to preserve header casing for HTTP/1.1 header keys Risk Level: Medium Testing: new integration test Part of #1558 Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-updates the build SHA (to include change to spdlog build)
-include fmtlib directly in files where spdlog was included in order to use fmt::format, and remove the spdlog include
-edit associated BUILD files to add fmtlib as an external_dep
#975