Don't depend on spdlog for fmt::format
#975
Labels
Comments
|
Some notes after testing spdlog 0.14 and chatting with @htuch on Gitter:
In the short term I think Envoy could move to spdlog 0.14 by changing the use of fmt::sprintf to fmt::format. Longer term making the dependencies explicit as @htuch suggests makes more sense. |
|
@moderation I believe @kmyerson is going to do this issue soon. @kmyerson can you also do the spdlog thirdparty dep upgrade at the same time since there is going to be some coordinate on making spdlog take the version of fmt that we want. |
|
Yes, I'll be working on this issue. I can do the spdlog thirdparty dep upgrade at the same time |
This was referenced Aug 29, 2017
|
This is fixed I think. |
rshriram
pushed a commit
to rshriram/envoy
that referenced
this issue
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
jpsim
pushed a commit
that referenced
this issue
Nov 28, 2022
With envoy-mobile built from Xcode 11.5, we are unable to consume it with Xcode 12.0 beta 3. I'm hoping this fixes it, the errors appear related: ``` deps/cache/dependencies/Envoy/current/Envoy.framework/Modules/Envoy.swiftmodule/x86_64.swiftinterface:137:28: error: overriding declaration requires an 'override' keyword @objc convenience public init() ^ override deps/cache/dependencies/Envoy/current/Envoy.framework/Modules/Envoy.swiftmodule/x86_64.swiftinterface:38:33: note: overridden declaration is here @objc override dynamic public init() ^ Modules/EnvoyFilters/Sources/EnvoyFilterManager.swift:1:8: error: failed to build module 'Envoy' from its module interface; the compiler that produced it, 'Apple Swift version 5.2.4 (swiftlang-1103.0.32.9 clang-1103.0.32.53)', may have used features that aren't supported by this compiler, 'Apple Swift version 5.3 (swiftlang-1200.0.22.4 clang-1200.0.25.1)' import Envoy ^ ``` This reverts commit ec6dfae8ae3ac8cbd0eef8571ca71b636a64a2df. Signed-off-by: Keith Smiley <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this issue
Nov 29, 2022
With envoy-mobile built from Xcode 11.5, we are unable to consume it with Xcode 12.0 beta 3. I'm hoping this fixes it, the errors appear related: ``` deps/cache/dependencies/Envoy/current/Envoy.framework/Modules/Envoy.swiftmodule/x86_64.swiftinterface:137:28: error: overriding declaration requires an 'override' keyword @objc convenience public init() ^ override deps/cache/dependencies/Envoy/current/Envoy.framework/Modules/Envoy.swiftmodule/x86_64.swiftinterface:38:33: note: overridden declaration is here @objc override dynamic public init() ^ Modules/EnvoyFilters/Sources/EnvoyFilterManager.swift:1:8: error: failed to build module 'Envoy' from its module interface; the compiler that produced it, 'Apple Swift version 5.2.4 (swiftlang-1103.0.32.9 clang-1103.0.32.53)', may have used features that aren't supported by this compiler, 'Apple Swift version 5.3 (swiftlang-1200.0.22.4 clang-1200.0.25.1)' import Envoy ^ ``` This reverts commit ec6dfae8ae3ac8cbd0eef8571ca71b636a64a2df. Signed-off-by: Keith Smiley <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a number of places where we depend on
spdlogjust to get at the string formatterfmt::format. This is not actually part ofspdlog, it's from https://github.com/fmtlib/fmt, whichspdlogbundles. In the interest of logging abstraction down the track, we should make the dependency more explicit and importfmtlib/fmtdirectly.The text was updated successfully, but these errors were encountered: