[fuzz] Scaled Load balancer fuzz to 60k hosts #13771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach <[email protected]>
Signed-off-by: Zach <[email protected]>
Signed-off-by: Zach <[email protected]>
|
/assign @asraa @htuch @adisuissa |
htuch
previously requested changes
Oct 27, 2020
| void LoadBalancerFuzzBase::clearStaticHostsHealthFlags() { | ||
| // Have to clear the hosts health flags here - how do we know what hosts to clear? | ||
| // The only outstanding health flags set are those that are set from hosts being placed in | ||
| // degraded and excluded. Thus, use the priority set pointer to know which flags to clear. |
There was a problem hiding this comment.
Could you also clear unconditionally?
There was a problem hiding this comment.
I think there is no unconditional flag clear, maybe a clearFlagForTest method or an ASSERT that the state matches expected?
There was a problem hiding this comment.
I think that my comment of "how do we know what hosts to clear?" is outdated. Since the only health flags that get set are those that are degraded and excluded, which will naturally be in that HostVector regardless? Thus making this work?
Signed-off-by: Zach <[email protected]>
Signed-off-by: Zach <[email protected]>
Signed-off-by: Zach <[email protected]>
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 30, 2020
* master: dns: preserve custom resolver after channel destruction (envoyproxy#13820) docs: Further updates to quick-start (envoyproxy#13793) wasm: update V8 to v8.7.220.10. (envoyproxy#13568) test: adding a test for CONNECT to an IP address (envoyproxy#13818) [fuzz] Scaled Load balancer fuzz to 60k hosts (envoyproxy#13771) Removed Circle-CI reference. (envoyproxy#13824) wasm: strip only Custom Sections with precompiled Wasm modules. (envoyproxy#13775) examples: Add dynamic configuration (filesystem) sandbox (envoyproxy#13783) apple dns: resolve IP addresses without calling Apple APIs (envoyproxy#13698) Signed-off-by: Michael Puncel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Scaled Load Balancer Fuzz to 60k hosts.
Additional Description: In order to truly represent the production search space for Load Balancing in regards to upstream hosts, the Load Balancer fuzzer requires at least 10k upstream hosts. This PR scales it up to 60k hosts. It fixes the bottleneck of constructing thousands of hosts each run by statically declaring the host vector. Also, this PR scales my random subset selector to 32 bits in order to randomly represent this search space, as before it was 8 bits and could only represent 256 hosts.
Risk Level: Low
Testing: Regression tests for 60k hosts.