Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm: update V8 to v8.7.220.10. #13568

Merged
merged 12 commits into from
Oct 30, 2020
Merged

wasm: update V8 to v8.7.220.10. #13568

merged 12 commits into from
Oct 30, 2020

Conversation

PiotrSikora
Copy link
Contributor

Signed-off-by: Piotr Sikora [email protected]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 14, 2020
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt).

🐱

Caused by: #13568 was opened by PiotrSikora.

see: more, trace.

htuch
htuch previously approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 14, 2020
@htuch
Copy link
Member

htuch commented Oct 14, 2020

@PiotrSikora the release build failure looks like its Wasm related.

@htuch htuch self-assigned this Oct 14, 2020
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 15, 2020
@PiotrSikora
Copy link
Contributor Author

It looks that there is a real regression in V8. Local testing didn't catch it, because precompiled tests were disabled for non-release builds in #12116 because of #12335.

I filled the issue with the V8 team (https://bugs.chromium.org/p/v8/issues/detail?id=11024), and I think it might be an easy fix, so I'm going to keep this PR open for now.

@PiotrSikora
review: fix format.
3e65434 
Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora
review: use release date.
0b41eb1 
Signed-off-by: Piotr Sikora <[email protected]>
@htuch htuch added the waiting label Oct 16, 2020
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #13568 was synchronize by PiotrSikora.

see: more, trace.

@PiotrSikora PiotrSikora changed the title wasm: update V8 to v8.7.220.5. wasm: update V8 to v8.7.220.10. Oct 29, 2020
moderation
moderation approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deps look OK

@PiotrSikora
Copy link
Contributor Author

Deps look OK

@moderation the magic keyword is /lgtm deps, @repokitteh doesn't understand anything else. Thanks!

@moderation
Copy link
Contributor

/lgtm deps

Arrrggh. I thought I approved this one through the review box.

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 30, 2020
@PiotrSikora
Copy link
Contributor Author

Arrrggh. I thought I approved this one through the review box.

You did approve it using the review box, thanks!. However, it turns out that @repokitteh doesn't recognize GitHub approvals, and it needs the /lgtm deps. Sorry for the noise, since I originally redirected you to the GitHub review box.

@mattklein123 mattklein123 merged commit 7ab7de1 into envoyproxy:master Oct 30, 2020
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 30, 2020
@mpuncel
Merge branch 'master' into mpuncel/http2-hc-goaway
bb0cc29 
* master:
  dns: preserve custom resolver after channel destruction (envoyproxy#13820)
  docs: Further updates to quick-start (envoyproxy#13793)
  wasm: update V8 to v8.7.220.10. (envoyproxy#13568)
  test: adding a test for CONNECT to an IP address (envoyproxy#13818)
  [fuzz] Scaled Load balancer fuzz to 60k hosts (envoyproxy#13771)
  Removed Circle-CI reference. (envoyproxy#13824)
  wasm: strip only Custom Sections with precompiled Wasm modules. (envoyproxy#13775)
  examples: Add dynamic configuration (filesystem) sandbox (envoyproxy#13783)
  apple dns: resolve IP addresses without calling Apple APIs (envoyproxy#13698)

Signed-off-by: Michael Puncel <[email protected]>
PiotrSikora added a commit to PiotrSikora/envoy that referenced this pull request Nov 19, 2020
@PiotrSikora
wasm: update V8 to v8.7.220.10. (envoyproxy#13568)
3bcf4fa 
Signed-off-by: Piotr Sikora <[email protected]>
istio-testing pushed a commit to istio/envoy that referenced this pull request Nov 20, 2020
@PiotrSikora @lizan
@ramaraochavali @asraa @keith @mathetake @kyessenov
Proxy-Wasm mega backport (#284)
5892439 
* build: update rules_rust to allow Rustc in RBE (envoyproxy#13595)

Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>

* fix macos v8 build (envoyproxy#13572)

Signed-off-by: Rama Chavali <[email protected]>

* wasm: update proxy-wasm-cpp-host (envoyproxy#13606)

The PR updates proxy-wasm-cpp-host dependency for enhancing the capability and fixing a bug in WASM extensions.

The change consists of three PRs in proxy-wasm-cpp-host:

1. proxy-wasm/proxy-wasm-cpp-host#68 @PiotrSikora
2. proxy-wasm/proxy-wasm-cpp-host#65 @mathetake (me)
3. proxy-wasm/proxy-wasm-cpp-host#64 @mathetake (me)

The code change can be found at proxy-wasm/proxy-wasm-cpp-host@49ed20e...c5658d3 .

1 & 2 enhance WASM capability, and 3 fixes a bug in situations where users share vm_id for multiple filters. For details, please take a look at these original PRs.

Signed-off-by: mathetake <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>

* wasm: re-enable tests with precompiled modules. (envoyproxy#13583)

Fixes envoyproxy#12335.

Signed-off-by: Piotr Sikora <[email protected]>

* wasm: flip the meaning of the "repository" in envoy_wasm_cc_binary(). (envoyproxy#13621)

Change the meaning of the "repository" parameter to refer to an external
Bazel repository, instead of using "@envoy" in targets that are included
in the Envoy repository.

This aligns with other envoy_* rules.

Signed-off-by: Piotr Sikora <[email protected]>

* build: support ppc64le with wasm (envoyproxy#13657)

The build has only been tested with gn git sha 5da62d5 as
recommended by ppc64 maintainers of the v8 runtime.

Signed-off-by: Christopher M. Luciano <[email protected]>

* wasm: remove no longer needed Emscripten metadata. (envoyproxy#13667)

Signed-off-by: Piotr Sikora <[email protected]>

* fix wasm compilation (envoyproxy#13765)

Signed-off-by: Asra Ali <[email protected]>

* wasm: strip only Custom Sections with precompiled Wasm modules. (envoyproxy#13775)

Signed-off-by: Piotr Sikora <[email protected]>

* build: don't build shared libraries for zlib and zlib-ng. (envoyproxy#13652)

Signed-off-by: Piotr Sikora <[email protected]>

* wasm: update V8 to v8.7.220.10. (envoyproxy#13568)

Signed-off-by: Piotr Sikora <[email protected]>

* build: exclude wee8/out from inputs (envoyproxy#13866)

If you build without sandboxing for performance, the output files from
this custom build genrule contained timestamps which caused it to
rebuild every single build.

Signed-off-by: Keith Smiley <[email protected]>

* tls: fix detection of the upstream connection close event. (envoyproxy#13858)

Fixes envoyproxy#13856.

Signed-off-by: Piotr Sikora <[email protected]>

* wasm: Force stop iteration after local response is sent (envoyproxy#13930)

Resolves envoyproxy#13857

ref:
-proxy-wasm/proxy-wasm-rust-sdk#44
-proxy-wasm/proxy-wasm-cpp-host#88
-proxy-wasm/proxy-wasm-cpp-host#93

Signed-off-by: mathetake <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>

* wasm: fix order of callbacks for paused requests. (envoyproxy#13840)

Fixes proxy-wasm/proxy-wasm-rust-sdk#43.

Signed-off-by: Piotr Sikora <[email protected]>

* wasm: fix network leak (envoyproxy#13836)

Signed-off-by: Kuat Yessenov <[email protected]>

Co-authored-by: Lizan Zhou <[email protected]>
Co-authored-by: Rama Chavali <[email protected]>
Co-authored-by: Takeshi Yoneda <[email protected]>
Co-authored-by: cmluciano <[email protected]>
Co-authored-by: asraa <[email protected]>
Co-authored-by: Keith Smiley <[email protected]>
Co-authored-by: Takeshi Yoneda <[email protected]>
Co-authored-by: Kuat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

@moderation moderation moderation approved these changes

@htuch htuch Awaiting requested review from htuch

@lizan lizan Awaiting requested review from lizan

Assignees

@htuch htuch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PiotrSikora @htuch @moderation @mattklein123