-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Adds a native windows filesystem implementation #13077
Conversation
…entation Signed-off-by: Sotiris Nanopoulos <[email protected]>
cc: @envoyproxy/windows-dev gimme one CI run to clean up any formatting or cascading build errors |
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple quick comments for discussion, but generally looking really good here, thanks!
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Attempting to bump coverage above threshold. Technically it shouldn't have been affected by the change since the code is a null-op in linux. |
Signed-off-by: Sotiris Nanopoulos <[email protected]>
|
Signed-off-by: Sotiris Nanopoulos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@envoyproxy/senior-maintainers can I also get a review from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup. Thanks!
Signed-off-by: Sotiris Nanopoulos [email protected]
Commit Message:
Refactor
filesystem_impl
to use win32 APIs instead of POSIX subsystem. Fixes issue #11655.Additional Description:
For easier review the major changes are the following:
file_shared_impl
because it relied onerrno
for error handling. This change cascades to the POSIX implementationRisk Level: Low
Testing: Already tested in
filesystem_impl_test
Docs Changes: N/A
Release Notes: N/A