-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: win32 Filesystem Impl uses POSIX subsystem, refactor to purely win32 APIs #11655
Comments
/assign @sunjayBhatia |
/assign @wrowe |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions. |
bumping to get rid of the stale tag |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions. |
Bumping to remove stale tag, will do this refactor after more pressing concerns of Envoy Windows Alpha are covered |
…entation Signed-off-by: Sotiris Nanopoulos <[email protected]>
Fixed by #13077 |
The win32 Filesystem impl code uses POSIX substem functions and should be refactored to use win32 APIs instead. The File IoError class should also be converted to use the platform agnostic
Envoy::errorDetails
function instead ofstrerror
as we will no longer be using POSIX on Windows.We believe coalescing on all win32 APIs will make error handling and reasoning about these operations easier and more consistent with the rest of the codebase. In #11565 we introduce a standardized mechanism for handling errors from winsock2 which are disjoint from POSIX errors. If we can eliminate as many uses of the POSIX subsystem we can, it should make for an easier time writing portable code. We only need a translation from win32 to generic Envoy errors on Windows and POSIX to generic Envoy errors on other platforms, the alternative being that Windows requires conversion of win32 errors to POSIX which is not possible in all cases and can be misleading when debugging.
The text was updated successfully, but these errors were encountered: