Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded RxJava from version 2 to 3 #919

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ ext {
supportConstraintLayout = 'androidx.constraintlayout:constraintlayout:2.0.1'

androidxPreference = 'androidx.preference:preference:1.1.1'
androidRoom = 'androidx.room:room-runtime:2.2.5'
androidRoomRxJava = 'androidx.room:room-rxjava2:2.2.5'
supportRoom = 'androidx.room:room-compiler:2.2.5'
androidRoom = 'androidx.room:room-runtime:2.4.2'
androidRoomRxJava = 'androidx.room:room-rxjava3:2.4.2'
supportRoom = 'androidx.room:room-compiler:2.4.2'


def lifecycle_version = "2.2.0"
Expand All @@ -102,11 +102,11 @@ ext {
retrofit2 = "com.squareup.retrofit2:retrofit:$retrofit_version"
retrofitGson2 = "com.squareup.retrofit2:converter-gson:$retrofit_version"
retrofitAdapters2 = "com.squareup.retrofit2:retrofit-adapters:$retrofit_version"
retrofitRxJava2 = "com.squareup.retrofit2:adapter-rxjava2:$retrofit_version"
retrofitRxJava3 = "com.squareup.retrofit2:adapter-rxjava3:$retrofit_version"

// RxJava dependencies.
rxJava = 'io.reactivex.rxjava2:rxjava:2.2.21'
rxAndroid = 'io.reactivex.rxjava2:rxandroid:2.1.1'
rxJava = 'io.reactivex.rxjava3:rxjava:3.0.0'
rxAndroid = 'io.reactivex.rxjava3:rxandroid:3.0.0'
rxPreferences = 'com.f2prateek.rx.preferences2:rx-preferences:2.0.1'

// RxBindings
Expand Down
3 changes: 2 additions & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@
sdk.dir=/home/matthes/opt/android/sdk
org.gradle.jvmargs=-Xmx2048M
android.useAndroidX=true
android.enableJetifier=true
android.enableJetifier=true
MAPBOX_DOWNLOADS_TOKEN=sk.eyJ1IjoiYWthc2hyYW1qeW90aGkiLCJhIjoiY2wxODc5ZGZlMGFueTNrcnp6Z3Q5aG9zcCJ9.a4WxmdZTsH8h_jzqfcWSqQ
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import org.envirocar.obd.events.PropertyKeyEvent;
import org.envirocar.obd.events.Timestamped;

import io.reactivex.Observable;
import io.reactivex.rxjava3.core.Observable;

/**
* TODO JavaDoc
Expand Down
11 changes: 6 additions & 5 deletions org.envirocar.app/src/org/envirocar/app/BaseApplication.java
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
import javax.inject.Inject;

import io.reactivex.disposables.CompositeDisposable;
import io.reactivex.disposables.Disposable;


/**
Expand Down Expand Up @@ -119,17 +120,17 @@ public void onCreate() {

// debug logging setting listener
this.disposables.add(
ApplicationSettings.getDebugLoggingObservable(this)
(Disposable) ApplicationSettings.getDebugLoggingObservable(this)
.doOnNext(this::setDebugLogging)
.doOnError(LOG::error)
.subscribe());
.doOnSubscribe());

// obfuscation setting changed listener
this.disposables.add(
ApplicationSettings.getObfuscationObservable(this)
(Disposable) ApplicationSettings.getObfuscationObservable(this)
.doOnNext(bool -> LOG.info("Obfuscation enabled: %s", bool.toString()))
.doOnError(LOG::error)
.subscribe());
.doOnSubscribe());

// register Intentfilter for logging screen changes
IntentFilter screenIntentFilter = new IntentFilter();
Expand All @@ -147,7 +148,7 @@ public void onCreate() {
}
})
.doOnError(LOG::error)
.subscribe());
.doOnSubscribe());
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import org.envirocar.app.R;
import org.envirocar.app.recording.RecordingType;

import io.reactivex.Observable;
import io.reactivex.rxjava3.core.Observable;

/**
* TODO JavaDoc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@
import javax.inject.Inject;
import javax.inject.Singleton;

import io.reactivex.Observable;
import io.reactivex.ObservableEmitter;
import io.reactivex.Scheduler;
import io.reactivex.observers.DisposableObserver;
import io.reactivex.schedulers.Schedulers;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.rxjava3.core.ObservableEmitter;
import io.reactivex.rxjava3.core.Scheduler;
import io.reactivex.rxjava3.observers.DisposableObserver;
import io.reactivex.rxjava3.schedulers.Schedulers;

/**
* @author dewall
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
import java.util.List;
import java.util.Map;

import io.reactivex.Observable;
import io.reactivex.rxjava3.core.Observable;


/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
import javax.inject.Inject;
import javax.inject.Singleton;

import io.reactivex.Observable;
import io.reactivex.schedulers.Schedulers;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.rxjava3.schedulers.Schedulers;

/**
* TODO JavaDoc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@

import javax.inject.Inject;

import io.reactivex.Completable;
import io.reactivex.Observable;
import io.reactivex.rxjava3.core.Completable;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.Single;
import io.reactivex.functions.Function;
import io.reactivex.schedulers.Schedulers;
import io.reactivex.rxjava3.schedulers.Schedulers;


/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
import javax.inject.Inject;
import javax.inject.Singleton;

import io.reactivex.Observable;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.ObservableOperator;
import io.reactivex.ObservableTransformer;
import io.reactivex.Observer;
import io.reactivex.functions.Function;
import io.reactivex.observers.DisposableObserver;
import io.reactivex.rxjava3.observers.DisposableObserver;


/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@
import javax.inject.Inject;
import javax.inject.Singleton;

import io.reactivex.Observable;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.ObservableSource;
import io.reactivex.ObservableTransformer;
import io.reactivex.android.schedulers.AndroidSchedulers;
import io.reactivex.functions.Function;
import io.reactivex.schedulers.Schedulers;
import io.reactivex.rxjava3.schedulers.Schedulers;

/**
* TODO JavaDoc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
import javax.inject.Inject;
import javax.inject.Singleton;

import io.reactivex.Observable;
import io.reactivex.rxjava3.core.Observable;


/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
import javax.inject.Inject;
import javax.inject.Singleton;

import io.reactivex.Completable;
import io.reactivex.rxjava3.core.Completable;

/**
* TODO JavaDoc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

import javax.inject.Inject;

import io.reactivex.observers.DisposableObserver;
import io.reactivex.rxjava3.observers.DisposableObserver;


/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@

import dagger.Module;
import dagger.Provides;
import io.reactivex.Scheduler;
import io.reactivex.rxjava3.core.Scheduler;
import io.reactivex.android.schedulers.AndroidSchedulers;
import io.reactivex.schedulers.Schedulers;
import io.reactivex.rxjava3.schedulers.Schedulers;

@Module
public class SchedulerModule {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@
import javax.inject.Inject;
import javax.inject.Singleton;

import io.reactivex.Observable;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.ObservableOperator;
import io.reactivex.Scheduler;
import io.reactivex.observers.DisposableObserver;
import io.reactivex.rxjava3.core.Scheduler;
import io.reactivex.rxjava3.observers.DisposableObserver;

/**
* @author dewall
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
import javax.inject.Inject;
import javax.inject.Singleton;

import io.reactivex.Observable;
import io.reactivex.Scheduler;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.rxjava3.core.Scheduler;

/**
* @author dewall
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@

import javax.inject.Inject;

import io.reactivex.Observable;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.ObservableSource;
import io.reactivex.ObservableTransformer;
import io.reactivex.Scheduler;
import io.reactivex.rxjava3.core.Scheduler;
import io.reactivex.functions.Function;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
import javax.inject.Inject;
import javax.inject.Singleton;

import io.reactivex.disposables.Disposable;
import io.reactivex.rxjava3.disposables.Disposable;

/**
* @author dewall
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

import io.reactivex.android.schedulers.AndroidSchedulers;
import io.reactivex.disposables.CompositeDisposable;
import io.reactivex.schedulers.Schedulers;
import io.reactivex.rxjava3.schedulers.Schedulers;

/**
* @author dewall
Expand Down Expand Up @@ -119,7 +119,7 @@ public void onCreate() {
}
})
.doOnError(LOG::error)
.subscribe());
.doOnSubscribe());
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

import java.util.Locale;

import io.reactivex.disposables.Disposable;
import io.reactivex.rxjava3.disposables.Disposable;


/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

import javax.inject.Inject;

import io.reactivex.Completable;
import io.reactivex.rxjava3.core.Completable;

/**
* @author dewall
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
import org.envirocar.core.events.recording.RecordingNewMeasurementEvent;
import org.envirocar.core.logging.Logger;

import io.reactivex.Scheduler;
import io.reactivex.rxjava3.core.Scheduler;
import io.reactivex.android.schedulers.AndroidSchedulers;


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
import java.text.SimpleDateFormat;
import java.util.Date;

import io.reactivex.Observable;
import io.reactivex.ObservableOnSubscribe;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.rxjava3.core.ObservableOnSubscribe;
import io.reactivex.ObservableTransformer;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,17 @@
import java.util.List;
import java.util.concurrent.TimeUnit;

import io.reactivex.Observable;
import io.reactivex.ObservableEmitter;
import io.reactivex.ObservableOnSubscribe;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.rxjava3.core.ObservableEmitter;
import io.reactivex.rxjava3.core.ObservableOnSubscribe;
import io.reactivex.ObservableTransformer;
import io.reactivex.Scheduler;
import io.reactivex.rxjava3.core.Scheduler;
import io.reactivex.android.schedulers.AndroidSchedulers;
import io.reactivex.disposables.CompositeDisposable;
import io.reactivex.disposables.Disposable;
import io.reactivex.rxjava3.disposables.Disposable;
import io.reactivex.functions.Consumer;
import io.reactivex.observers.DisposableObserver;
import io.reactivex.schedulers.Schedulers;
import io.reactivex.rxjava3.observers.DisposableObserver;
import io.reactivex.rxjava3.schedulers.Schedulers;

/**
* @author dewall
Expand Down Expand Up @@ -192,7 +192,7 @@ public void startRecording(Service service, RecordingListener listener) {
// subscribe for preference changes
disposables.add(ApplicationSettings.getTrackTrimDurationObservable(context)
.doOnNext(newDuration -> this.trackTrimDuration = newDuration)
.subscribe());
.doOnSubscribe());
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,14 @@
import java.io.IOException;
import java.util.concurrent.TimeUnit;

import io.reactivex.Observable;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.ObservableTransformer;
import io.reactivex.Scheduler;
import io.reactivex.rxjava3.core.Scheduler;
import io.reactivex.android.schedulers.AndroidSchedulers;
import io.reactivex.disposables.CompositeDisposable;
import io.reactivex.disposables.Disposable;
import io.reactivex.observers.DisposableObserver;
import io.reactivex.schedulers.Schedulers;
import io.reactivex.rxjava3.disposables.Disposable;
import io.reactivex.rxjava3.observers.DisposableObserver;
import io.reactivex.rxjava3.schedulers.Schedulers;

/**
* @author dewall
Expand Down Expand Up @@ -163,7 +163,7 @@ public void startRecording(Service service, RecordingListener listener) {
// subscribe for preference changes
disposables.add(ApplicationSettings.getCampaignProfileObservable(context)
.doOnNext(campaign -> this.cycleCommandProfile = getCycleCommandProfile(campaign))
.subscribe());
.doOnSubscribe());
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;

import io.reactivex.Observable;
import io.reactivex.ObservableEmitter;
import io.reactivex.ObservableOnSubscribe;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.rxjava3.core.ObservableEmitter;
import io.reactivex.rxjava3.core.ObservableOnSubscribe;
import io.reactivex.android.schedulers.AndroidSchedulers;
import io.reactivex.disposables.Disposable;
import io.reactivex.rxjava3.disposables.Disposable;
import io.reactivex.functions.Cancellable;


Expand Down
Loading