Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded RxJava from version 2 to 3 #919

Closed

Conversation

Akash-Ramjyothi
Copy link
Contributor

Fixes: #918.

Description:

Updated all the dependencies and usage of RxJava from version 2 to 3 and reactive types (First Revision).

@SebaDro
Copy link
Contributor

SebaDro commented Jun 13, 2022

Hey @Akash-Ramjyothi . Please, change your pull request so that it will be merged into the develop branch. Things have to be tested before they will be merged into the master branch. In addition, make sure that everything is working fine after the library upgrade. This also includes automate Gradle builds via GitHub Actions.

@asaikarthikeya
Copy link
Member

Hello @SebaDro. This PR is a part of our GSoC 2022 efforts, Is it okay to directly direct the changes to develop branch? Or create a separate branch named gsoc2022 (similar to last year) and later merge it into develop once gsoc ends?

@SebaDro
Copy link
Contributor

SebaDro commented Jun 27, 2022

Upgrading RxJava from 2 to 3 may come with some braking changes, so many things have to be tested afterwards. Therefore, I'd suggest to do all changes and implementations as part of a separate GSoC branch.

@SebaDro SebaDro closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade RxJava from version 2 to 3
3 participants