Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: v4.0.0 #915

Merged
merged 15 commits into from
Jan 1, 2024
Merged

chore!: v4.0.0 #915

merged 15 commits into from
Jan 1, 2024

Conversation

morremeyer
Copy link
Member

@morremeyer morremeyer commented Jan 1, 2024

Overview

This is the v4.0.0 PR. It contains multiple breaking changes that are relevant for users.

Breaking changes

  • The module version is bumped to v4 (ca0c352)
  • API v1 and v2 are removed (66bbdef)
  • Overspend handling is removed. To keep budgets intact, overspend affecting the envelope is subtracted from the allocation with a migration (c61f4f2)
  • Database migrations needed for v3 are removed (f52ae06)
  • Deprecated fields are removed from the API (dcbafb3)
  • The OCI image is now rootless (9c7634b)

Commits

  • chore!: remove API v1 and v2
  • chore!: Bump module version to v4
  • chore!: remove overspend handling
  • chore!: Remove v3 database migrations
  • chore!: remove reconciled field
  • chore!: removed deprecated fields
  • docs: add upgrading notes
  • refactor: rename hidden field to archived for all resources
  • test: update api version in parsing tests
  • fixup! docs: add upgrading notes
  • fixup! chore!: remove overspend handling
  • feat!: use rootless OCI image
  • chore: remove outdated comment

This removes the API versions v1 and v2.
This commit also removes the allocation model and migrates all allocations to month configs.

BREAKING CHANGE: removes /v1 and /v2 APIs
BREAKING CHANGE: bumps the module version to v4
This removes overspend handling since it is a hack against clean budgeting.
Existing overspend is migrated by subtracting possible overspend from next month's allocation.

BREAKING CHANGE: Overspend handling is removed since it is a hack against clean budgeting.
BREAKING CHANGES: Removes database migrations for v3
This field never worked as intended and is removed now.

This also fixes a bug where the reconciled sum was not calculated
correctly when using the reconciledSource and reconciledDestination fields.

BREAKING CHANGE: "reconciled" field is removed from transactions
BREAKING CHANGE: Removes the renameRuleId field from transaction previews and the
month field from envelope month resources
With this change, the image is built rootless.

BREAKING CHANGE: Container is now running rootless.
You need to update the ownership of your database file to uid and gid 65532.
For details, see the updating instructions.
@morremeyer morremeyer requested a review from a team as a code owner January 1, 2024 20:48
@morremeyer morremeyer changed the title chore/v4.0.0 chore!: v4.0.0 Jan 1, 2024
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (6bf9273) 81.30% compared to head (5a34df7) 83.92%.

Files Patch % Lines
pkg/models/database.go 60.57% 31 Missing and 10 partials ⚠️
internal/types/month.go 35.71% 6 Missing and 3 partials ⚠️
pkg/importer/parser/ynab4/parse.go 95.60% 2 Missing and 2 partials ⚠️
pkg/models/envelope.go 83.33% 2 Missing and 1 partial ⚠️
pkg/controllers/account.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
+ Coverage   81.30%   83.92%   +2.61%     
==========================================
  Files          58       43      -15     
  Lines        7217     4690    -2527     
==========================================
- Hits         5868     3936    -1932     
+ Misses       1127      611     -516     
+ Partials      222      143      -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant