Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MonthConfigs #441

Merged
merged 3 commits into from
Nov 7, 2022
Merged

feat: MonthConfigs #441

merged 3 commits into from
Nov 7, 2022

Conversation

morremeyer
Copy link
Member

This PR adds the MonthConfigs resource. With that resource, configurations for a month can be stored.

Allocations will be migrated to this resource later, see #440.

Commits:

  • chore: split model into ID and Timestamps
  • feat: add month-config resource and API endpoints
  • docs: remove double declaration of route config

@morremeyer morremeyer requested a review from a team as a code owner November 7, 2022 23:18
This enables models that do not use an ID field as primary key
This new resource will group configurations that are specific for a month for
a specific envelope. For now, it will only contain the overspend handling.

Future versions will deprecate the Allocation resource in favor of this endpoint.
@morremeyer morremeyer changed the title feat/configurable rollover feat: MonthConfigs Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 87.66% // Head: 88.01% // Increases project coverage by +0.35% 🎉

Coverage data is based on head (39dfb5c) compared to base (449e243).
Patch coverage: 92.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   87.66%   88.01%   +0.35%     
==========================================
  Files          23       24       +1     
  Lines        2562     2754     +192     
==========================================
+ Hits         2246     2424     +178     
- Misses        251      261      +10     
- Partials       65       69       +4     
Impacted Files Coverage Δ
pkg/models/account.go 100.00% <ø> (ø)
pkg/models/budget.go 93.29% <ø> (ø)
pkg/models/envelope.go 86.11% <ø> (ø)
pkg/controllers/budget.go 66.93% <50.00%> (ø)
pkg/controllers/month_config.go 92.67% <92.67%> (ø)
pkg/controllers/account.go 96.10% <100.00%> (ø)
pkg/controllers/allocation.go 98.07% <100.00%> (ø)
pkg/controllers/category.go 94.70% <100.00%> (ø)
pkg/controllers/envelope.go 95.00% <100.00%> (ø)
pkg/controllers/month.go 81.42% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@morremeyer morremeyer merged commit 402df4d into main Nov 7, 2022
@morremeyer morremeyer deleted the feat/configurable-rollover branch November 7, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant