Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify public-facing message API #56

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Oct 30, 2024

  • re-export digest module from session (should have been done when Digest was added to SessionParameters)
  • rename *MessageBundle to *Message, and Signed/VerifiedMessage to Signed/VerifiedMessagePart. Fixes Simplify public-facing type names #42
  • make VerifiedMessage generic over Verifier and not the whole SessionParameters
  • add Message::destination() to simplify the user's life a bit.

@coveralls
Copy link

coveralls commented Oct 30, 2024

Pull Request Test Coverage Report for Build 11600047451

Details

  • 54 of 61 (88.52%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 71.184%

Changes Missing Coverage Covered Lines Changed/Added Lines %
manul/src/session/transcript.rs 6 7 85.71%
manul/src/session/evidence.rs 4 7 57.14%
manul/src/session/message.rs 18 21 85.71%
Files with Coverage Reduction New Missed Lines %
manul/src/session/evidence.rs 1 41.03%
Totals Coverage Status
Change from base Build 11599314557: 0.03%
Covered Lines: 1497
Relevant Lines: 2103

💛 - Coveralls

@fjarri fjarri merged commit 24b0914 into entropyxyz:master Oct 30, 2024
8 checks passed
@fjarri fjarri deleted the naming branch October 30, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify public-facing type names
2 participants