Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify public-facing type names #42

Closed
fjarri opened this issue Oct 24, 2024 · 0 comments · Fixed by #56
Closed

Simplify public-facing type names #42

fjarri opened this issue Oct 24, 2024 · 0 comments · Fixed by #56
Assignees
Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Oct 24, 2024

There are some elements of the public API that refer to their implementation and in general are a little too unwieldy. An example would be MessageBundle/VerifiedMessageBundle. These are better changed to something like Message/ProcessedMessage. This will mean that the current internal types containing "single" (echo or direct) messages will have to be renamed to not be confused with them (to SingleMessagePart etc?)

@fjarri fjarri added API Involves backwards-incompatible changes of the public API code quality Making things simpler labels Oct 24, 2024
@fjarri fjarri added this to the v1.0.0 milestone Oct 24, 2024
@fjarri fjarri mentioned this issue Oct 24, 2024
@fjarri fjarri modified the milestones: v1.0.0, v0.1.0 Oct 30, 2024
@fjarri fjarri self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant