mixmix/custom-config #264
Open
mixmix/custom-config #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
force-pushed
the
mixmix/custom-config
branch
from
fe90ac6
to
8236b29
Compare
2 tasks
|
resolve conflicts, get ready for review |
|
NOTE: this is passing all tests but will need a really close review + smoke test before merge. |
|
@rh0delta I want you to try and break this. I think I got everything but dial up the pedantry with this one. I turned of |
rh0delta
reviewed
Nov 7, 2024
Comment on lines
-30
to
-42
| .argParser(aliasOrEndpoint => { | ||
| /* see if it's a raw endpoint */ | ||
| if (aliasOrEndpoint.match(/^wss?:\/\//)) return aliasOrEndpoint | ||
|
|
||
| /* look up endpoint-alias */ | ||
| const storedConfig = getConfigOrNull() | ||
| const endpoint = storedConfig?.endpoints?.[aliasOrEndpoint] | ||
| if (!endpoint) throw Error('unknown endpoint alias: ' + aliasOrEndpoint) | ||
|
|
||
| return endpoint | ||
| }) | ||
| .default('wss://testnet.entropy.xyz/') | ||
| // NOTE: default cannot be "test-net" as argParser only runs if the -e/--endpoint flag | ||
| // or ENTROPY_ENDPOINT env set |
There was a problem hiding this comment.
what was the need to delete all of this? I'm all for it, just wondering the reason why
src/common/utils-cli.ts
Outdated
Comment on lines
63
to
66
| // NOTE: (mix) we expect config to be initialised (see hook in cli) | ||
| // ...there was some reason we wanted to preserve a `null` state, | ||
| // but I can't recall if it's still relevant, and we need to check | ||
| // the downstream ramifications of it being `null` |
There was a problem hiding this comment.
i think the null state was for fresh installs, where the config is created in the XDG standardized directory if there is no config found initially.
src/common/utils-cli.ts
Outdated
Comment on lines
68
to
78
| const account = parseAccountOption(storedConfig, opts.account) | ||
| // if this account is not the default selectedAccount, make it so | ||
| if (storedConfig.selectedAccount !== account.name) { | ||
| await config.set( | ||
| { | ||
| ...storedConfig, | ||
| selectedAccount: account.name | ||
| }, | ||
| opts.config | ||
| ) | ||
| } |
There was a problem hiding this comment.
should we refactor this to be a separate function? might be cleaner
Comment on lines
+86
to
+95
| export function absolutePath (somePath: string) { | ||
| switch (somePath.charAt(0)) { | ||
| case '.': | ||
| return join(process.cwd(), somePath) | ||
| case '~': | ||
| return join(homedir(), somePath.slice(1)) | ||
| default: | ||
| return somePath | ||
| } | ||
| } |
* [NayNay] Testing Mix's Custom Config - the general purpose of the custom config works, however there is alot of work to be done regarding error handling - i have only started testing the custom config feature with a file that doesn't exist: ./custom-files/custom-config-<#>.json - this originally caused issues on the tui and did not allow for anything to start until the tui eventually errored out - similar errors were found with the cli as well - ive fixed the tui for the most part - but theres still lots to do to fix the cli in terms of proper error handling * Update src/common/utils-cli.ts * Update src/common/utils-cli.ts * Update src/common/utils-cli.ts * Update src/common/utils.ts --------- Co-authored-by: mix irving <[email protected]>
rh0delta
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of a PR chain:
mixmix/config-types → mixmix/load-entropy → mixmix/custom-config
The purpose of this PR is to be able to set a custom config file path for CLI
NOTES
argParsercannot beasync.action, probablyloadEntropy--configas the other leaf actionsentropy tuiorentropy ui