[NayNay] Testing Mix's Custom Config #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the general purpose of the custom config works, however there is alot of work to be done regarding error handling - i have only started testing the custom config feature with a file that doesn't exist: ./custom-files/custom-config-<#>.json - this originally caused issues on the tui and did not allow for anything to start until the tui eventually errored out - similar errors were found with the cli as well - ive fixed the tui for the most part - but theres still lots to do to fix the cli in terms of proper error handling
mixmix
approved these changes
Nov 13, 2024
| if (!account) { | ||
| console.error(`AccountError: No account with name or address "${addressOrName}"`) | ||
| if (config.accounts.length && !account) { | ||
| console.error(ERROR_RED + `AccountError: No account with name or address "${addressOrName}"`) |
There was a problem hiding this comment.
we should probably make a printError
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Screenshots (if applicable)
Additional Context
Checklist
CHANGELOG.mdentry.github.com:entropyxyz/entropy-docs, where necessary.