Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] fix(linux): generic icon on Wayland sessions #3737

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Merrit
Copy link
Contributor

@Merrit Merrit commented Oct 16, 2024

This change sets the program name to the application ID, which helps various
systems like GTK and desktop environments map this running application to its
corresponding .desktop file. This ensures better integration by allowing the
application to be recognized beyond its binary name.

Notably, this is necessary on Wayland to map the running application window to
the desktop file, and therefore apply the correct icon.

This is the same fix that is applied to new Flutter projects.

Before After
Window before-window after-window
Taskbar before-taskbar after-taskbar

How to test

  • Run main on a Wayland session
  • Note the generic Wayland logo for the icon in the window decorations, taskbar, task switcher (alt+tab), and overview effects
  • Run this branch, note the correct ente auth icon is now used

This change sets the program name to the
application ID, which helps various systems like
GTK and desktop environments map this running
application to its corresponding .desktop file.
This ensures better integration by allowing the
application to be recognized beyond its binary
name.
@Merrit Merrit changed the title fix(linux): generic icon on Wayland sessions [auth] fix(linux): generic icon on Wayland sessions Oct 16, 2024
@Merrit
Copy link
Contributor Author

Merrit commented Oct 16, 2024

This may also resolve #3621 & #3029

@ua741
Copy link
Member

ua741 commented Oct 17, 2024

Thank you for this PR :)
The lint is failing due to an unrelated change. I will merge this PR and look into the lint issue separately.

@ua741 ua741 merged commit 607dfad into ente-io:main Oct 17, 2024
1 of 2 checks passed
@Merrit Merrit deleted the linux-icons branch October 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants