Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] Auth lockscreen fixes #3545

Merged
merged 7 commits into from
Oct 7, 2024
Merged

[auth] Auth lockscreen fixes #3545

merged 7 commits into from
Oct 7, 2024

Conversation

AmanRajSinghMourya
Copy link
Contributor

Description

  1. Removed the logout button from the lockscreen if app in without backup state
  2. Show a warning dialog when user try to set the app lock for the 1st time

Tests

@ashilkn
Copy link
Member

ashilkn commented Oct 4, 2024

@AmanRajSinghMourya Can change the copy to "You have chosen to proceed without backups. If you forget your applock, you will be locked out from accessing your data."

@@ -146,10 +149,27 @@ class _SecuritySectionWidgetState extends State<SecuritySectionWidget> {
trailingIcon: Icons.chevron_right_outlined,
trailingIconIsMuted: true,
onTap: () async {
ButtonResult? result;
if (_config.hasOptedForOfflineMode() &&
!LockScreenSettings.instance.getOfflineModeWarningStatus()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names aren't used coherently. getOfflineModeWarningStatus returns a bool but isn't clear how the status and boolean returns are related.

getOfflineModeWarningStatus returns the key ls_show_offline_mode_warning. So it's expected if getOfflineModeWarningStatus returns false, we should not show the warning. But the use of getOfflineModeWarningStatus here isn't following that expectation.

@ashilkn ashilkn merged commit c56a964 into main Oct 7, 2024
2 checks passed
@ashilkn ashilkn deleted the auth_lock_fixes branch October 7, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants