-
-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[auth] Auth lockscreen fixes #3545
Conversation
@AmanRajSinghMourya Can change the copy to "You have chosen to proceed without backups. If you forget your applock, you will be locked out from accessing your data." |
@@ -146,10 +149,27 @@ class _SecuritySectionWidgetState extends State<SecuritySectionWidget> { | |||
trailingIcon: Icons.chevron_right_outlined, | |||
trailingIconIsMuted: true, | |||
onTap: () async { | |||
ButtonResult? result; | |||
if (_config.hasOptedForOfflineMode() && | |||
!LockScreenSettings.instance.getOfflineModeWarningStatus()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Names aren't used coherently. getOfflineModeWarningStatus
returns a bool
but isn't clear how the status and boolean returns are related.
getOfflineModeWarningStatus
returns the key ls_show_offline_mode_warning
. So it's expected if getOfflineModeWarningStatus
returns false, we should not show the warning. But the use of getOfflineModeWarningStatus
here isn't following that expectation.
Description
Tests